tyler.durden
/
centreon-plugins
mirror of https://github.com/centreon/centreon-plugins.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

+ Put interface status before speed. So you can get interface down error.

This commit is contained in:
Quentin Garnier 2014-05-21 13:38:35 +02:00
parent 4c6477b813
commit f9e3cc0fbc
1 changed files with 15 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
snmp_standard/mode/traffic.pm
View File

@ -163,6 +163,21 @@ sub run {
foreach (sort @{$self->{interface_id_selected}}) { foreach (sort @{$self->{interface_id_selected}}) {
my $display_value = $self->get_display_value(id => $_); my $display_value = $self->get_display_value(id => $_);
if ($operstatus[$result->{$oid_operstatus . "." . $_} - 1] ne "up") {
if (!defined($self->{option_results}->{skip}) && (!defined($result->{$oid_adminstatus . "." . $_}) || $operstatus[$result->{$oid_adminstatus . "." . $_} - 1] eq 'up') ) {
$self->{output}->output_add(severity => 'CRITICAL',
short_msg => "Interface '" . $display_value . "' is not ready: " . $operstatus[$result->{$oid_operstatus . "." . $_} - 1]);
} else {
# Avoid getting "buffer creation..." alone
if (defined($self->{option_results}->{interface}) && !defined($self->{option_results}->{use_regexp})) {
$self->{output}->output_add(severity => 'OK',
short_msg => "Interface '" . $display_value . "' is not up (normal state)");
}
$self->{output}->output_add(long_msg => "Skip interface '" . $display_value . "'.");
}
next;
}
# Manage interface speed # Manage interface speed
my $interface_speed; my $interface_speed;
if (defined($self->{option_results}->{speed}) && $self->{option_results}->{speed} ne '') { if (defined($self->{option_results}->{speed}) && $self->{option_results}->{speed} ne '') {
@ -186,22 +201,6 @@ sub run {
} }
} }
if ($operstatus[$result->{$oid_operstatus . "." . $_} - 1] ne "up") {
if (!defined($self->{option_results}->{skip}) && (!defined($result->{$oid_adminstatus . "." . $_}) || $operstatus[$result->{$oid_adminstatus . "." . $_} - 1] eq 'up') ) {
$self->{output}->output_add(severity => 'CRITICAL',
short_msg => "Interface '" . $display_value . "' is not ready: " . $operstatus[$result->{$oid_operstatus . "." . $_} - 1]);
} else {
# Avoid getting "buffer creation..." alone
if (defined($self->{option_results}->{interface}) && !defined($self->{option_results}->{use_regexp})) {
$self->{output}->output_add(severity => 'OK',
short_msg => "Interface '" . $display_value . "' is not up (normal state)");
}
$self->{output}->output_add(long_msg => "Skip interface '" . $display_value . "'.");
}
next;
}
my $old_mode = $self->{statefile_value}->get(name => 'mode_' . $_); my $old_mode = $self->{statefile_value}->get(name => 'mode_' . $_);
$new_datas->{'mode_' . $_} = '32'; $new_datas->{'mode_' . $_} = '32';