From fd94931ea9241fc936485f0c1a1ab93c3a8d0fdd Mon Sep 17 00:00:00 2001 From: Sims24 Date: Tue, 6 Oct 2015 10:44:57 +0200 Subject: [PATCH 1/4] Create offset.pm +Add first work on NTP offset mode https://github.com/centreon/centreon-plugins/issues/81 --- apps/protocols/ntp/mode/offset.pm | 127 ++++++++++++++++++++++++++++++ 1 file changed, 127 insertions(+) create mode 100644 apps/protocols/ntp/mode/offset.pm diff --git a/apps/protocols/ntp/mode/offset.pm b/apps/protocols/ntp/mode/offset.pm new file mode 100644 index 000000000..120962516 --- /dev/null +++ b/apps/protocols/ntp/mode/offset.pm @@ -0,0 +1,127 @@ +# +# Copyright 2015 Centreon (http://www.centreon.com/) +# +# Centreon is a full-fledged industry-strength solution that meets +# the needs in IT infrastructure and application monitoring for +# service performance. +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +package apps::protocols::ntp::mode::offset; + +use base qw(centreon::plugins::mode); + +use strict; +use warnings; +use Net::NTP; + +sub new { + my ($class, %options) = @_; + my $self = $class->SUPER::new(package => __PACKAGE__, %options); + bless $self, $class; + + $self->{version} = '1.0'; + $options{options}->add_options(arguments => + { + "ntp-host:s" => { name => 'ntp_host' }, + "port:s" => { name => 'port', default => 123 }, + "warning:s" => { name => 'warning' }, + "critical:s" => { name => 'critical' }, + "timeout:s" => { name => 'timeout', default => 30 }, + }); + return $self; +} + +sub check_options { + my ($self, %options) = @_; + $self->SUPER::init(%options); + + if (($self->{perfdata}->threshold_validate(label => 'warning', value => $self->{option_results}->{warning})) == 0) { + $self->{output}->add_option_msg(short_msg => "Wrong warning threshold '" . $self->{option_results}->{warning} . "'."); + $self->{output}->option_exit(); + } + if (($self->{perfdata}->threshold_validate(label => 'critical', value => $self->{option_results}->{critical})) == 0) { + $self->{output}->add_option_msg(short_msg => "Wrong critical threshold '" . $self->{option_results}->{critical} . "'."); + $self->{output}->option_exit(); + } + if (!defined($self->{option_results}->{ntp_host})) { + $self->{output}->add_option_msg(short_msg => "Please set the ntp_host option"); + $self->{output}->option_exit(); + } +} + +sub run { + my ($self, %options) = @_; + + my %ntp; + eval { + $Net::NTP::TIMEOUT = $self->{option_results}->{timeout}; + %ntp = get_ntp_response($self->{option_results}->{ntp_host}, $self->{option_results}->{port}); + }; + if ($@) { + $self->{output}->output_add(severity => 'CRITICAL', + short_msg => "Couldn't connect to ntp server: " . $@); + $self->{output}->display(); + $self->{output}->exit(); + } + + my $localtime = time(); + my $offset = ($ntp{'Receive Timestamp'} - $ntp{'Originate Timestamp'}) + ($ntp{'Transmit Timestamp'} - $localtime) / 2); + + my $exit = $self->{perfdata}->threshold_check(value => $offset, + threshold => [ { label => 'critical', 'exit_litteral' => 'critical' }, { label => 'warning', exit_litteral => 'warning' } ]); + $self->{output}->output_add(severity => $exit, + short_msg => sprintf("Response time %.3fs", $offset)); + $self->{output}->perfdata_add(label => "time", + value => sprintf('%.3f', $offset), + warning => $self->{perfdata}->get_perfdata_for_output(label => 'warning'), + critical => $self->{perfdata}->get_perfdata_for_output(label => 'critical')); + + $self->{output}->display(); + $self->{output}->exit(); +} + +1; + +__END__ + +=head1 MODE + +Check Ntp server response. + +=over 8 + +=item B<--ntp_host> + +Ntp server address or FQDN + +=item B<--port> + +Port used (Default: 123) + +=item B<--timeout> + +Threshold for NTP timeout + +=item B<--warning> + +Threshold warning in seconds + +=item B<--critical> + +Threshold critical in seconds + +=back + +=cut From 05d7921c7a534b4d314ae4264983683db5274096 Mon Sep 17 00:00:00 2001 From: Sims24 Date: Mon, 12 Oct 2015 14:47:18 +0200 Subject: [PATCH 2/4] +add offset reference in plugin.pm Add a line for offset mode --- apps/protocols/ntp/plugin.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/apps/protocols/ntp/plugin.pm b/apps/protocols/ntp/plugin.pm index 9147f005e..6b659809e 100644 --- a/apps/protocols/ntp/plugin.pm +++ b/apps/protocols/ntp/plugin.pm @@ -32,7 +32,8 @@ sub new { $self->{version} = '0.1'; %{$self->{modes}} = ( - 'response-time' => 'apps::protocols::ntp::mode::responsetime', + 'response-time' => 'apps::protocols::ntp::mode::responsetime', + 'offset' => 'apps::protocols::ntp::mode::offset', ); return $self; From bf3c4995d131043943d62ad74f1d816115498e47 Mon Sep 17 00:00:00 2001 From: Sims24 Date: Mon, 12 Oct 2015 14:50:18 +0200 Subject: [PATCH 3/4] +fix copy/paste in output and add verbose message --- apps/protocols/ntp/mode/offset.pm | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/apps/protocols/ntp/mode/offset.pm b/apps/protocols/ntp/mode/offset.pm index 120962516..0c53f0766 100644 --- a/apps/protocols/ntp/mode/offset.pm +++ b/apps/protocols/ntp/mode/offset.pm @@ -82,7 +82,9 @@ sub run { my $exit = $self->{perfdata}->threshold_check(value => $offset, threshold => [ { label => 'critical', 'exit_litteral' => 'critical' }, { label => 'warning', exit_litteral => 'warning' } ]); $self->{output}->output_add(severity => $exit, - short_msg => sprintf("Response time %.3fs", $offset)); + short_msg => sprintf("Offset: %.3fs", $offset)); + $self->{output}->output_add(long_msg => sprintf("Host has %.5fs with its time server reference %s", $offset, $self->{option_results}->{ntp_host})); + $self->{output}->perfdata_add(label => "time", value => sprintf('%.3f', $offset), warning => $self->{perfdata}->get_perfdata_for_output(label => 'warning'), @@ -120,7 +122,7 @@ Threshold warning in seconds =item B<--critical> -Threshold critical in seconds +Threshold critical in seconds (e.g @10:10 means CRITICAL if offset is not between -10 and +10 seconds) =back From 69b47cece223ed496eabe43a6271ce15aa5da0b3 Mon Sep 17 00:00:00 2001 From: Sims24 Date: Mon, 12 Oct 2015 14:50:56 +0200 Subject: [PATCH 4/4] +complete long output ... --- apps/protocols/ntp/mode/offset.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/protocols/ntp/mode/offset.pm b/apps/protocols/ntp/mode/offset.pm index 0c53f0766..998006944 100644 --- a/apps/protocols/ntp/mode/offset.pm +++ b/apps/protocols/ntp/mode/offset.pm @@ -83,7 +83,7 @@ sub run { threshold => [ { label => 'critical', 'exit_litteral' => 'critical' }, { label => 'warning', exit_litteral => 'warning' } ]); $self->{output}->output_add(severity => $exit, short_msg => sprintf("Offset: %.3fs", $offset)); - $self->{output}->output_add(long_msg => sprintf("Host has %.5fs with its time server reference %s", $offset, $self->{option_results}->{ntp_host})); + $self->{output}->output_add(long_msg => sprintf("Host has an offset of %.5fs with its time server reference %s", $offset, $self->{option_results}->{ntp_host})); $self->{output}->perfdata_add(label => "time", value => sprintf('%.3f', $offset),