mirror of https://github.com/docker/compose.git
delete DockerClientTestCase.client class attribute on tearDownClass
This is a docker.client.Client and therefore contains a connection pool, so each subclass of DockerClientTestCase can end up holding on to up to 10 Unix socket file descriptors after the tests contained in the sub-class are complete. Before this by the end of a test run I was seeing ~100 open file descriptors, ~80 of which were Unix domain sockets. By cleaning these up only 15 Unix sockets remain at the end (out of ~25 fds, the rest of which are the Python interpretter, opened libraries etc). Signed-off-by: Ian Campbell <ian.campbell@docker.com>
This commit is contained in:
parent
6649e9aba3
commit
0483bcb472
|
@ -63,6 +63,10 @@ class DockerClientTestCase(unittest.TestCase):
|
||||||
|
|
||||||
cls.client = docker_client(Environment(), version)
|
cls.client = docker_client(Environment(), version)
|
||||||
|
|
||||||
|
@classmethod
|
||||||
|
def tearDownClass(cls):
|
||||||
|
del cls.client
|
||||||
|
|
||||||
def tearDown(self):
|
def tearDown(self):
|
||||||
for c in self.client.containers(
|
for c in self.client.containers(
|
||||||
all=True,
|
all=True,
|
||||||
|
|
Loading…
Reference in New Issue