From 053d225824c6e873491466701bef0469d3ddca3d Mon Sep 17 00:00:00 2001 From: Nicolas De Loof Date: Wed, 14 May 2025 17:04:42 +0200 Subject: [PATCH] append .exe to provider name doing executable lookup on windows Signed-off-by: Nicolas De Loof --- pkg/compose/plugins.go | 2 +- pkg/compose/plugins_windows.go | 23 +++++++++++++++++++++++ pkg/compose/suffix_unix.go | 23 +++++++++++++++++++++++ 3 files changed, 47 insertions(+), 1 deletion(-) create mode 100644 pkg/compose/plugins_windows.go create mode 100644 pkg/compose/suffix_unix.go diff --git a/pkg/compose/plugins.go b/pkg/compose/plugins.go index ab5a76432..bbf2c2ff6 100644 --- a/pkg/compose/plugins.go +++ b/pkg/compose/plugins.go @@ -155,7 +155,7 @@ func (s *composeService) getPluginBinaryPath(provider string) (path string, err path = plugin.Path } if manager.IsNotFound(err) { - path, err = exec.LookPath(provider) + path, err = exec.LookPath(executable(provider)) } return path, err } diff --git a/pkg/compose/plugins_windows.go b/pkg/compose/plugins_windows.go new file mode 100644 index 000000000..327b3e4c1 --- /dev/null +++ b/pkg/compose/plugins_windows.go @@ -0,0 +1,23 @@ +//go:build windows + +/* + Copyright 2020 Docker Compose CLI authors + + Licensed under the Apache License, Version 2.0 (the "License"); + you may not use this file except in compliance with the License. + You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +*/ + +package compose + +func executable(s string) string { + return s + ".exe" +} diff --git a/pkg/compose/suffix_unix.go b/pkg/compose/suffix_unix.go new file mode 100644 index 000000000..59595384c --- /dev/null +++ b/pkg/compose/suffix_unix.go @@ -0,0 +1,23 @@ +//go:build !windows + +/* + Copyright 2020 Docker Compose CLI authors + + Licensed under the Apache License, Version 2.0 (the "License"); + you may not use this file except in compliance with the License. + You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +*/ + +package compose + +func executable(s string) string { + return s +}