tyler.durden
/
compose
mirror of https://github.com/docker/compose.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Don't panic on bind mount 

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
This commit is contained in:
Nicolas De Loof 2020-11-10 08:38:46 +01:00
parent 2b8fa9934e
commit 06fd442a53
No known key found for this signature in database
GPG Key ID: 9858809D6F8F6E7E
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
ecs/compatibility.go
View File

@ -27,9 +27,10 @@ import (
func (b *ecsAPIService) checkCompatibility(project *types.Project) error { func (b *ecsAPIService) checkCompatibility(project *types.Project) error {
var checker compatibility.Checker = &fargateCompatibilityChecker{ var checker compatibility.Checker = &fargateCompatibilityChecker{
compatibility.AllowList{ AllowList: compatibility.AllowList{
Supported: compatibleComposeAttributes, Supported: compatibleComposeAttributes,
}, },
projet: project,
} }
compatibility.Check(project, checker) compatibility.Check(project, checker)
for _, err := range checker.Errors() { for _, err := range checker.Errors() {
@ -46,6 +47,7 @@ func (b *ecsAPIService) checkCompatibility(project *types.Project) error {
type fargateCompatibilityChecker struct { type fargateCompatibilityChecker struct {
compatibility.AllowList compatibility.AllowList
projet *types.Project
} }
var compatibleComposeAttributes = []string{ var compatibleComposeAttributes = []string{
@ -91,7 +93,6 @@ var compatibleComposeAttributes = []string{
"services.user", "services.user",
"services.volumes", "services.volumes",
"services.volumes.read_only", "services.volumes.read_only",
"services.volumes.source",
"services.volumes.target", "services.volumes.target",
"services.working_dir", "services.working_dir",
"secrets.external", "secrets.external",
@ -120,6 +121,15 @@ func (c *fargateCompatibilityChecker) CheckPortsPublished(p *types.ServicePortCo
} }
} }
func (c *fargateCompatibilityChecker) CheckVolumesSource(config *types.ServiceVolumeConfig) {
if config.Type == types.VolumeTypeBind {
c.Incompatible("ECS Fargate does not support bind mounts from host")
}
if config.Type == types.VolumeTypeTmpfs {
c.Incompatible("ECS Fargate does not support tmpfs")
}
}
func (c *fargateCompatibilityChecker) CheckCapAdd(service *types.ServiceConfig) { func (c *fargateCompatibilityChecker) CheckCapAdd(service *types.ServiceConfig) {
add := []string{} add := []string{}
for _, cap := range service.CapAdd { for _, cap := range service.CapAdd {