tyler.durden
/
compose
mirror of https://github.com/docker/compose.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

trace: do not block connecting to OTLP endpoint (#10882) 

This was left over from debugging, but we should not block.
OTel will handle the connection in the background.

Signed-off-by: Milas Bowman <milas.bowman@docker.com>
This commit is contained in:
Milas Bowman 2023-08-08 15:47:18 -04:00 committed by GitHub
parent fd8ab2f7ac
commit 0be8e4a676
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
internal/tracing/docker_context.go
View File

@ -69,7 +69,6 @@ func traceClientFromDockerContext(dockerCli command.Cli, otelEnv envMap) (otlptr
cfg.Endpoint, cfg.Endpoint,
grpc.WithContextDialer(DialInMemory), grpc.WithContextDialer(DialInMemory),
grpc.WithTransportCredentials(insecure.NewCredentials()), grpc.WithTransportCredentials(insecure.NewCredentials()),
grpc.WithBlock(),
) )
if err != nil { if err != nil {
return nil, fmt.Errorf("initializing otel connection from docker context metadata: %v", err) return nil, fmt.Errorf("initializing otel connection from docker context metadata: %v", err)