From 15089886c2b261d75545bfc853d55804596fe13a Mon Sep 17 00:00:00 2001 From: Emil Hessman Date: Sat, 29 Sep 2018 18:30:52 +0200 Subject: [PATCH] Avoid modifying mutable default value Rationale: http://effbot.org/zone/default-values.htm Signed-off-by: Emil Hessman --- compose/service.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/compose/service.py b/compose/service.py index 3327c77f8..5ae2ac3af 100644 --- a/compose/service.py +++ b/compose/service.py @@ -197,7 +197,9 @@ class Service(object): def __repr__(self): return ''.format(self.name) - def containers(self, stopped=False, one_off=False, filters={}, labels=None): + def containers(self, stopped=False, one_off=False, filters=None, labels=None): + if filters is None: + filters = {} filters.update({'label': self.labels(one_off=one_off) + (labels or [])}) result = list(filter(None, [