Proper variable naming

This commit is contained in:
Djordje Lukic 2020-05-04 09:57:52 +02:00
parent 885fd799e1
commit 152d4119d2
1 changed files with 18 additions and 18 deletions

View File

@ -14,7 +14,7 @@ import (
) )
type containerService struct { type containerService struct {
cgc containerinstance.ContainerGroupsClient containerGroupsClient containerinstance.ContainerGroupsClient
ctx store.AciContext ctx store.AciContext
} }
@ -29,56 +29,56 @@ func getter() interface{} {
} }
func New(ctx context.Context) (containers.ContainerService, error) { func New(ctx context.Context) (containers.ContainerService, error) {
cc := apicontext.CurrentContext(ctx) currentContext := apicontext.CurrentContext(ctx)
contextStore, err := store.New() contextStore, err := store.New()
if err != nil { if err != nil {
return nil, err return nil, err
} }
metadata, err := contextStore.Get(cc, getter) metadata, err := contextStore.Get(currentContext, getter)
if err != nil { if err != nil {
return nil, errors.Wrap(err, "wrong context type") return nil, errors.Wrap(err, "wrong context type")
} }
tc, _ := metadata.Metadata.Data.(store.AciContext) aciContext, _ := metadata.Metadata.Data.(store.AciContext)
auth, _ := auth.NewAuthorizerFromCLI() auth, _ := auth.NewAuthorizerFromCLI()
containerGroupsClient := containerinstance.NewContainerGroupsClient(tc.SubscriptionID) containerGroupsClient := containerinstance.NewContainerGroupsClient(aciContext.SubscriptionID)
containerGroupsClient.Authorizer = auth containerGroupsClient.Authorizer = auth
return &containerService{ return &containerService{
cgc: containerGroupsClient, containerGroupsClient: containerGroupsClient,
ctx: tc, ctx: aciContext,
}, nil }, nil
} }
func (cs *containerService) List(ctx context.Context) ([]containers.Container, error) { func (cs *containerService) List(ctx context.Context) ([]containers.Container, error) {
var cg []containerinstance.ContainerGroup var containerGroups []containerinstance.ContainerGroup
result, err := cs.cgc.ListByResourceGroup(ctx, cs.ctx.ResourceGroup) result, err := cs.containerGroupsClient.ListByResourceGroup(ctx, cs.ctx.ResourceGroup)
if err != nil { if err != nil {
return []containers.Container{}, err return []containers.Container{}, err
} }
for result.NotDone() { for result.NotDone() {
cg = append(cg, result.Values()...) containerGroups = append(containerGroups, result.Values()...)
if err := result.NextWithContext(ctx); err != nil { if err := result.NextWithContext(ctx); err != nil {
return []containers.Container{}, err return []containers.Container{}, err
} }
} }
res := []containers.Container{} res := []containers.Container{}
for _, c := range cg { for _, containerGroup := range containerGroups {
group, err := cs.cgc.Get(ctx, cs.ctx.ResourceGroup, *c.Name) group, err := cs.containerGroupsClient.Get(ctx, cs.ctx.ResourceGroup, *containerGroup.Name)
if err != nil { if err != nil {
return []containers.Container{}, err return []containers.Container{}, err
} }
for _, d := range *group.Containers { for _, container := range *group.Containers {
status := "Unknown" status := "Unknown"
if d.InstanceView != nil && d.InstanceView.CurrentState != nil { if container.InstanceView != nil && container.InstanceView.CurrentState != nil {
status = *d.InstanceView.CurrentState.State status = *container.InstanceView.CurrentState.State
} }
res = append(res, containers.Container{ res = append(res, containers.Container{
ID: *d.Name, ID: *container.Name,
Image: *d.Image, Image: *container.Image,
Status: status, Status: status,
}) })
} }