tyler.durden/compose
1
0
Fork 0
mirror of https://github.com/docker/compose.git synced 2025-07-23 21:54:40 +02:00
Code Issues Packages Projects Releases Wiki Activity

Do not restrict docker inspect to 1 arg, can be zero (inspect current context), one or several.

Browse Source 
Especially, inspect with zero param is already used by VSCode. Cf https://github.com/docker/desktop-microsoft/issues/19
This commit is contained in:
Guillaume Tardif 2020-06-17 22:20:23 +02:00
parent 1623584303
commit 1bb2909d1a
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
cli/cmd/context/inspect.go
View File

@ -37,10 +37,12 @@ func inspectCommand() *cobra.Command {
cmd := &cobra.Command{ cmd := &cobra.Command{
Use: "inspect", Use: "inspect",
Short: "Display detailed information on one or more contexts", Short: "Display detailed information on one or more contexts",
Args: cobra.ExactArgs(1),
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
return mobycli.ExecCmd(cmd) return mobycli.ExecCmd(cmd)
}, },
} }
// flags matching delegated command in moby cli
flags := cmd.Flags()
flags.StringP("format", "f", "", "Format the output using the given Go template")
return cmd return cmd
} }

5
tests/e2e/e2e_test.go
View File

@ -79,6 +79,11 @@ func (s *E2eSuite) TestInspectDefaultContext() {
Expect(output).To(ContainSubstring(`"Name": "default"`)) Expect(output).To(ContainSubstring(`"Name": "default"`))
} }
func (s *E2eSuite) TestInspectContextNoArgs() {
output := s.NewDockerCommand("context", "inspect").ExecOrDie()
Expect(output).To(ContainSubstring(`"Name": "default"`))
}
func (s *E2eSuite) TestContextCreateParseErrorDoesNotDelegateToLegacy() { func (s *E2eSuite) TestContextCreateParseErrorDoesNotDelegateToLegacy() {
It("should dispay new cli error when parsing context create flags", func() { It("should dispay new cli error when parsing context create flags", func() {
_, err := s.NewDockerCommand("context", "create", "aci", "--subscription-id", "titi").Exec() _, err := s.NewDockerCommand("context", "create", "aci", "--subscription-id", "titi").Exec()