From 20a8f01269b7646e7be23b09959afc2c17747309 Mon Sep 17 00:00:00 2001 From: Nicolas De Loof Date: Wed, 30 Sep 2020 15:17:45 +0200 Subject: [PATCH] Don't set securityGroup name, as all compose apps will create a `DefaultNetwork` Signed-off-by: Nicolas De Loof --- ecs/awsResources.go | 1 - ecs/testdata/simple/simple-cloudformation-conversion.golden | 1 - 2 files changed, 2 deletions(-) diff --git a/ecs/awsResources.go b/ecs/awsResources.go index 2ba44e5e5..829fc6bbc 100644 --- a/ecs/awsResources.go +++ b/ecs/awsResources.go @@ -189,7 +189,6 @@ func (b *ecsAPIService) ensureNetworks(r *awsResources, project *types.Project, securityGroup := networkResourceName(name) template.Resources[securityGroup] = &ec2.SecurityGroup{ GroupDescription: fmt.Sprintf("%s Security Group for %s network", project.Name, name), - GroupName: securityGroup, VpcId: r.vpc, Tags: networkTags(project, net), } diff --git a/ecs/testdata/simple/simple-cloudformation-conversion.golden b/ecs/testdata/simple/simple-cloudformation-conversion.golden index 5e1bc7798..07200659c 100644 --- a/ecs/testdata/simple/simple-cloudformation-conversion.golden +++ b/ecs/testdata/simple/simple-cloudformation-conversion.golden @@ -37,7 +37,6 @@ "DefaultNetwork": { "Properties": { "GroupDescription": "TestSimpleConvert Security Group for default network", - "GroupName": "DefaultNetwork", "Tags": [ { "Key": "com.docker.compose.project",