tyler.durden/compose
1
0
Fork 0
mirror of https://github.com/docker/compose.git synced 2025-07-24 06:04:57 +02:00
Code Issues Packages Projects Releases Wiki Activity

Check that port definition contains source and dest

Browse Source
This commit is contained in:
Djordje Lukic 2020-05-04 11:45:34 +02:00
parent e992b4192c
commit 28808f3f6d
2 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
cli/cmd/run/opts.go
View File

@ -1,6 +1,7 @@
package run package run
import ( import (
"fmt"
"strconv" "strconv"
"strings" "strings"
@ -17,11 +18,14 @@ func toPorts(ports []string) ([]containers.Port, error) {
for _, port := range ports { for _, port := range ports {
parts := strings.Split(port, ":") parts := strings.Split(port, ":")
source, err := strconv.ParseUint(parts[0], 10, 32) if len(parts) != 2 {
return nil, fmt.Errorf("unable to parse ports %q", port)
}
source, err := strconv.Atoi(parts[0])
if err != nil { if err != nil {
return nil, err return nil, err
} }
destination, err := strconv.ParseUint(parts[1], 10, 32) destination, err := strconv.Atoi(parts[1])
if err != nil { if err != nil {
return nil, err return nil, err
} }
@ -34,7 +38,7 @@ func toPorts(ports []string) ([]containers.Port, error) {
return result, nil return result, nil
} }
func (r *runOpts) ToContainerConfig(image string) (containers.ContainerConfig, error) { func (r *runOpts) toContainerConfig(image string) (containers.ContainerConfig, error) {
publish, err := toPorts(r.publish) publish, err := toPorts(r.publish)
if err != nil { if err != nil {
return containers.ContainerConfig{}, err return containers.ContainerConfig{}, err

2
cli/cmd/run/run.go
View File

@ -59,7 +59,7 @@ func runRun(ctx context.Context, image string, opts runOpts) error {
return err return err
} }
project, err := opts.ToContainerConfig(image) project, err := opts.toContainerConfig(image)
if err != nil { if err != nil {
return err return err
} }