tyler.durden
/
compose
mirror of https://github.com/docker/compose.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Support pull from ECR 

close #58

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
This commit is contained in:
Nicolas De Loof 2020-05-25 16:49:58 +02:00
parent e9fe3b2864
commit 3283bceac6
No known key found for this signature in database
GPG Key ID: 9858809D6F8F6E7E
4 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
ecs/pkg/amazon/cloudformation.go
View File

@ -120,6 +120,7 @@ func (c client) Convert(project *compose.Project) (*cloudformation.Template, err
Policies: rolePolicies, Policies: rolePolicies,
ManagedPolicyArns: []string{ ManagedPolicyArns: []string{
ECSTaskExecutionPolicy, ECSTaskExecutionPolicy,
ECRReadOnlyPolicy,
}, },
} }
template.Resources[taskDefinition] = definition template.Resources[taskDefinition] = definition

1
ecs/pkg/amazon/iam.go
View File

@ -2,6 +2,7 @@ package amazon
const ( const (
ECSTaskExecutionPolicy = "arn:aws:iam::aws:policy/service-role/AmazonECSTaskExecutionRolePolicy" ECSTaskExecutionPolicy = "arn:aws:iam::aws:policy/service-role/AmazonECSTaskExecutionRolePolicy"
ECRReadOnlyPolicy = "arn:aws:iam::aws:policy/AmazonEC2ContainerRegistryReadOnly"
ActionGetSecretValue = "secretsmanager:GetSecretValue" ActionGetSecretValue = "secretsmanager:GetSecretValue"
ActionGetParameters = "ssm:GetParameters" ActionGetParameters = "ssm:GetParameters"

3
ecs/pkg/amazon/testdata/simple/simple-cloudformation-conversion.golden vendored
View File

@ -217,7 +217,8 @@
"Version": "2012-10-17" "Version": "2012-10-17"
}, },
"ManagedPolicyArns": [ "ManagedPolicyArns": [
"arn:aws:iam::aws:policy/service-role/AmazonECSTaskExecutionRolePolicy" "arn:aws:iam::aws:policy/service-role/AmazonECSTaskExecutionRolePolicy",
"arn:aws:iam::aws:policy/AmazonEC2ContainerRegistryReadOnly"
] ]
}, },
"Type": "AWS::IAM::Role" "Type": "AWS::IAM::Role"

3
ecs/pkg/amazon/testdata/simple/simple-cloudformation-with-overrides-conversion.golden vendored
View File

@ -217,7 +217,8 @@
"Version": "2012-10-17" "Version": "2012-10-17"
}, },
"ManagedPolicyArns": [ "ManagedPolicyArns": [
"arn:aws:iam::aws:policy/service-role/AmazonECSTaskExecutionRolePolicy" "arn:aws:iam::aws:policy/service-role/AmazonECSTaskExecutionRolePolicy",
"arn:aws:iam::aws:policy/AmazonEC2ContainerRegistryReadOnly"
] ]
}, },
"Type": "AWS::IAM::Role" "Type": "AWS::IAM::Role"