tyler.durden/compose
1
0
Fork 0
mirror of https://github.com/docker/compose.git synced 2025-07-23 13:45:00 +02:00
Code Issues Packages Projects Releases Wiki Activity

test: fix race in e2e build test

Browse Source 
This was running two tests in parallel that would build/delete the
same images. Run in serial instead since that's not safe.

Signed-off-by: Milas Bowman <milas.bowman@docker.com>
This commit is contained in:
Milas Bowman 2023-03-24 10:32:55 -04:00
parent 72260d615d
commit 36625ed229
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/e2e/build_test.go
View File

@ -257,7 +257,7 @@ func TestBuildImageDependencies(t *testing.T) {
} }
t.Run("ClassicBuilder", func(t *testing.T) { t.Run("ClassicBuilder", func(t *testing.T) {
cli := NewParallelCLI(t, WithEnv( cli := NewCLI(t, WithEnv(
"DOCKER_BUILDKIT=0", "DOCKER_BUILDKIT=0",
"COMPOSE_FILE=./fixtures/build-dependencies/compose.yaml", "COMPOSE_FILE=./fixtures/build-dependencies/compose.yaml",
)) ))
@ -265,7 +265,7 @@ func TestBuildImageDependencies(t *testing.T) {
}) })
t.Run("BuildKit", func(t *testing.T) { t.Run("BuildKit", func(t *testing.T) {
cli := NewParallelCLI(t, WithEnv( cli := NewCLI(t, WithEnv(
"DOCKER_BUILDKIT=1", "DOCKER_BUILDKIT=1",
"COMPOSE_FILE=./fixtures/build-dependencies/compose.yaml", "COMPOSE_FILE=./fixtures/build-dependencies/compose.yaml",
)) ))