tyler.durden/compose
1
0
Fork 0
mirror of https://github.com/docker/compose.git synced 2025-07-23 13:45:00 +02:00
Code Issues Packages Projects Releases Wiki Activity

Reduce up() cyclomatic complexity

Browse Source 
Signed-off-by: Joffrey F <joffrey@docker.com>
This commit is contained in:
Joffrey F 2017-08-28 18:18:31 -07:00
parent 376389d7a5
commit 3cb22fa94a
1 changed files with 35 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
compose/cli/main.py
View File

@ -969,7 +969,31 @@ class TopLevelCommand(object):
if cascade_stop: if cascade_stop:
print("Aborting on container exit...") print("Aborting on container exit...")
all_containers = self.project.containers(service_names=options['SERVICE'], stopped=True)
exit_code = compute_exit_code(
exit_value_from, attached_containers, cascade_starter, all_containers
)
self.project.stop(service_names=service_names, timeout=timeout)
sys.exit(exit_code)
@classmethod
def version(cls, options):
"""
Show version informations
Usage: version [--short]
Options:
--short Shows only Compose's version number.
"""
if options['--short']:
print(__version__)
else:
print(get_version_info('full'))
def compute_exit_code(exit_value_from, attached_containers, cascade_starter, all_containers):
exit_code = 0 exit_code = 0
if exit_value_from: if exit_value_from:
candidates = list(filter( candidates = list(filter(
@ -991,29 +1015,13 @@ class TopLevelCommand(object):
else: else:
exit_code = candidates[0].inspect()['State']['ExitCode'] exit_code = candidates[0].inspect()['State']['ExitCode']
else: else:
for e in self.project.containers(service_names=options['SERVICE'], stopped=True): for e in all_containers:
if (not e.is_running and cascade_starter == e.name): if (not e.is_running and cascade_starter == e.name):
if not e.exit_code == 0: if not e.exit_code == 0:
exit_code = e.exit_code exit_code = e.exit_code
break break
self.project.stop(service_names=service_names, timeout=timeout) return exit_code
sys.exit(exit_code)
@classmethod
def version(cls, options):
"""
Show version informations
Usage: version [--short]
Options:
--short Shows only Compose's version number.
"""
if options['--short']:
print(__version__)
else:
print(get_version_info('full'))
def convergence_strategy_from_opts(options): def convergence_strategy_from_opts(options):