From 467c73186996465a7bb1e5873ab829d2d1c90f42 Mon Sep 17 00:00:00 2001
From: Mazz Mosley <mazz@houseofmnowster.com>
Date: Fri, 25 Sep 2015 17:18:46 +0100
Subject: [PATCH] address PR feedback

Signed-off-by: Mazz Mosley <mazz@houseofmnowster.com>
---
 compose/project.py                | 7 +++++--
 compose/service.py                | 5 +----
 tests/integration/service_test.py | 8 +++++++-
 tests/unit/service_test.py        | 2 +-
 4 files changed, 14 insertions(+), 8 deletions(-)

diff --git a/compose/project.py b/compose/project.py
index 919a201f1..999c28904 100644
--- a/compose/project.py
+++ b/compose/project.py
@@ -37,7 +37,10 @@ def sort_service_dicts(services):
         return [link.split(':')[0] for link in links]
 
     def get_service_names_from_volumes_from(volumes_from):
-        return [volume_from.split(':')[0] for volume_from in volumes_from]
+        return [
+            parse_volume_from_spec(volume_from).source
+            for volume_from in volumes_from
+        ]
 
     def get_service_dependents(service_dict, services):
         name = service_dict['name']
@@ -195,7 +198,7 @@ class Project(object):
                         raise ConfigurationError(
                             'Service "%s" mounts volumes from "%s", which is '
                             'not the name of a service or container.' % (
-                                volume_from_config,
+                                service_dict['name'],
                                 volume_from_spec.source))
                 volumes_from.append(volume_from_spec)
             del service_dict['volumes_from']
diff --git a/compose/service.py b/compose/service.py
index 79a138aac..f2f82f6ce 100644
--- a/compose/service.py
+++ b/compose/service.py
@@ -6,6 +6,7 @@ import os
 import re
 import sys
 from collections import namedtuple
+from operator import attrgetter
 
 import enum
 import six
@@ -1009,10 +1010,6 @@ def parse_volume_from_spec(volume_from_config):
     else:
         source, mode = parts
 
-    if mode not in ('rw', 'ro'):
-        raise ConfigError("VolumeFrom %s has invalid mode (%s), should be "
-                          "one of: rw, ro." % (volume_from_config, mode))
-
     return VolumeFromSpec(source, mode)
 
 
diff --git a/tests/integration/service_test.py b/tests/integration/service_test.py
index 306060960..64ce2c658 100644
--- a/tests/integration/service_test.py
+++ b/tests/integration/service_test.py
@@ -273,7 +273,13 @@ class ServiceTest(DockerClientTestCase):
             command=["top"],
             labels={LABEL_PROJECT: 'composetest'},
         )
-        host_service = self.create_service('host', volumes_from=[VolumeFromSpec(volume_service, 'rw'), VolumeFromSpec(volume_container_2, 'rw')])
+        host_service = self.create_service(
+            'host',
+            volumes_from=[
+                VolumeFromSpec(volume_service, 'rw'),
+                VolumeFromSpec(volume_container_2, 'rw')
+            ]
+        )
         host_container = host_service.create_container()
         host_service.start_container(host_container)
         self.assertIn(volume_container_1.id + ':rw',
diff --git a/tests/unit/service_test.py b/tests/unit/service_test.py
index f85d34d2a..48e31b11b 100644
--- a/tests/unit/service_test.py
+++ b/tests/unit/service_test.py
@@ -379,7 +379,7 @@ class ServiceTest(unittest.TestCase):
             client=self.mock_client,
             net=ServiceNet(Service('other')),
             links=[(Service('one'), 'one')],
-            volumes_from=[Service('two')])
+            volumes_from=[VolumeFromSpec(Service('two'), 'rw')])
 
         config_dict = service.config_dict()
         expected = {