diff --git a/ecs/compatibility.go b/ecs/compatibility.go index 339ff0e42..76500bbe5 100644 --- a/ecs/compatibility.go +++ b/ecs/compatibility.go @@ -135,3 +135,12 @@ func (c *fargateCompatibilityChecker) CheckLoggingDriver(config *types.LoggingCo c.Unsupported("services.logging.driver %s is not supported", config.Driver) } } + +func (c *fargateCompatibilityChecker) CheckUlimits(service *types.ServiceConfig) { + for k := range service.Ulimits { + if k != "nofile" { + c.Unsupported("services.ulimits.%s is not supported by Fargate", k) + delete(service.Ulimits, k) + } + } +} diff --git a/ecs/down.go b/ecs/down.go index 7b0bedddd..62fe046ba 100644 --- a/ecs/down.go +++ b/ecs/down.go @@ -28,12 +28,12 @@ func (b *ecsAPIService) Down(ctx context.Context, project string) error { return err } - err = resources.apply(awsTypeCapacityProvider, delete(ctx, b.aws.DeleteCapacityProvider)) + err = resources.apply(awsTypeCapacityProvider, doDelete(ctx, b.aws.DeleteCapacityProvider)) if err != nil { return err } - err = resources.apply(awsTypeAutoscalingGroup, delete(ctx, b.aws.DeleteAutoscalingGroup)) + err = resources.apply(awsTypeAutoscalingGroup, doDelete(ctx, b.aws.DeleteAutoscalingGroup)) if err != nil { return err } @@ -62,7 +62,7 @@ func (b *ecsAPIService) previousStackEvents(ctx context.Context, project string) return previousEvents, nil } -func delete(ctx context.Context, delete func(ctx context.Context, arn string) error) func(r stackResource) error { +func doDelete(ctx context.Context, delete func(ctx context.Context, arn string) error) func(r stackResource) error { return func(r stackResource) error { w := progress.ContextWriter(ctx) w.Event(progress.Event{