From 630c600929f1f254933ad4b8d05f69df02bc3eb6 Mon Sep 17 00:00:00 2001 From: IKEDA Yasuyuki Date: Sat, 9 Jul 2022 12:05:22 +0900 Subject: [PATCH 1/2] Link to BUILDING.md for testing instructions Signed-off-by: IKEDA Yasuyuki --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 55be2a92b..8bb8cca64 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -125,7 +125,7 @@ Fork the repository and make changes on your fork in a feature branch: Submit unit tests for your changes. Go has a great test framework built in; use it! Take a look at existing tests for inspiration. [Run the full test -suite](README.md) on your branch before +suite](BUILDING.md) on your branch before submitting a pull request. Write clean code. Universally formatted code promotes ease of writing, reading, From d789b2e426ca13aac205656af24963cf9f0e34a8 Mon Sep 17 00:00:00 2001 From: IKEDA Yasuyuki Date: Sat, 30 Jul 2022 17:18:39 +0900 Subject: [PATCH 2/2] Improve descriptions about tests in CONTRIBUTING.md Signed-off-by: IKEDA Yasuyuki --- CONTRIBUTING.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 8bb8cca64..2f9ebd847 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -124,9 +124,10 @@ Fork the repository and make changes on your fork in a feature branch: issue. Submit unit tests for your changes. Go has a great test framework built in; use -it! Take a look at existing tests for inspiration. [Run the full test -suite](BUILDING.md) on your branch before -submitting a pull request. +it! Take a look at existing tests for inspiration. Also end-to-end tests are +available. Run the full test suite, both unit tests and e2e tests on your +branch before submitting a pull request. See [BUILDING.md](BUILDING.md) for +instructions to build and run tests. Write clean code. Universally formatted code promotes ease of writing, reading, and maintenance. Always run `gofmt -s -w file.go` on each changed file before