Add flake8 and fix errors.

Signed-off-by: Daniel Nephin <dnephin@gmail.com>
This commit is contained in:
Daniel Nephin 2014-07-15 13:22:16 -07:00 committed by Daniel Nephin
parent 0dc55fda45
commit 50a24bc3bf
9 changed files with 24 additions and 13 deletions

View File

@ -1,4 +1,4 @@
from __future__ import unicode_literals
from .service import Service
from .service import Service # noqa:flake8
__version__ = '0.5.1'

View File

@ -8,7 +8,6 @@ import os
import re
import yaml
from ..packages import six
import sys
from ..project import Project
from ..service import ConfigError
@ -19,6 +18,7 @@ from . import errors
log = logging.getLogger(__name__)
class Command(DocoptCommand):
base_dir = '.'

View File

@ -281,13 +281,13 @@ class TopLevelCommand(Command):
try:
num = int(num)
except ValueError:
raise UserError('Number of containers for service "%s" is not a number' % service)
raise UserError('Number of containers for service "%s" is not a '
'number' % service_name)
try:
self.project.get_service(service_name).scale(num)
except CannotBeScaledError:
raise UserError('Service "%s" cannot be scaled because it specifies a port on the host. If multiple containers for this service were created, the port would clash.\n\nRemove the ":" from the port definition in fig.yml so Docker can choose a random port for each container.' % service_name)
def start(self, options):
"""
Start existing containers.
@ -357,5 +357,6 @@ class TopLevelCommand(Command):
print("Gracefully stopping... (press Ctrl+C again to force)")
self.project.stop(service_names=service_names)
def list_containers(containers):
return ", ".join(c.name for c in containers)

View File

@ -1,6 +1,7 @@
from __future__ import unicode_literals
from __future__ import absolute_import
class Container(object):
"""
Represents a Docker container, constructed from the output of

View File

@ -38,6 +38,7 @@ def sort_service_dicts(services):
return sorted_services
class Project(object):
"""
A collection of services.
@ -216,6 +217,6 @@ class ConfigurationError(Exception):
def __str__(self):
return self.msg
class DependencyError(ConfigurationError):
pass

View File

@ -132,7 +132,6 @@ class Service(object):
self.remove_stopped()
def remove_stopped(self, **options):
for c in self.containers(stopped=True):
if not c.is_running:
@ -459,12 +458,14 @@ def split_port(port):
external_port = (external_ip,)
return internal_port, external_port
def split_env(env):
if '=' in env:
return env.split('=', 1)
else:
return env, None
def resolve_env(key, val):
if val is not None:
return key, val

View File

@ -2,3 +2,4 @@ mock==1.0.1
nose==1.3.0
pyinstaller==2.1
unittest2
flake8

View File

@ -7,3 +7,9 @@ deps =
-rrequirements-dev.txt
commands =
nosetests {posargs}
flake8 fig
[flake8]
# ignore line-length for now
ignore = E501,E203
exclude = fig/packages/