Merge pull request #4288 from tntC4stl3/fix_404_issue

Fix 404 issue, change APIError to more accureate ImageNotFound
This commit is contained in:
Joffrey F 2017-01-09 16:43:57 -08:00 committed by GitHub
commit 545153f117
1 changed files with 3 additions and 5 deletions

View File

@ -10,6 +10,7 @@ from operator import attrgetter
import enum
import six
from docker.errors import APIError
from docker.errors import ImageNotFound
from docker.errors import NotFound
from docker.types import LogConfig
from docker.utils.ports import build_port_bindings
@ -323,11 +324,8 @@ class Service(object):
def image(self):
try:
return self.client.inspect_image(self.image_name)
except APIError as e:
if e.response.status_code == 404 and e.explanation and 'No such image' in str(e.explanation):
raise NoSuchImageError("Image '{}' not found".format(self.image_name))
else:
raise
except ImageNotFound:
raise NoSuchImageError("Image '{}' not found".format(self.image_name))
@property
def image_name(self):