tyler.durden/compose
1
0
Fork 0
mirror of https://github.com/docker/compose.git synced 2025-04-08 17:05:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

build: ensure file handles properly closed (#5298)

Browse Source 
I've been running the test suite (`./internal/engine` in particular)
with `-count X` a lot recently to catch timing-related test failures.

After running enough times, the tests start failing due to too many
open files, so I did an audit and found a few places where files or
readers weren't always being closed.
This commit is contained in:
Milas Bowman 2021-12-17 11:32:28 -05:00 committed by Nicolas De loof
parent ab84b6ac5b
commit 6fc0b6ff27
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
pkg/watch/notify_test.go
View File

@ -181,10 +181,11 @@ func TestNewDirectoriesAreRecursivelyWatched(t *testing.T) {
// change something inside sub directory // change something inside sub directory
changeFilePath := filepath.Join(subPath, "change") changeFilePath := filepath.Join(subPath, "change")
_, err := os.OpenFile(changeFilePath, os.O_RDONLY|os.O_CREATE, 0666) file, err := os.OpenFile(changeFilePath, os.O_RDONLY|os.O_CREATE, 0666)
if err != nil { if err != nil {
t.Fatal(err) t.Fatal(err)
} }
_ = file.Close()
f.assertEvents(subPath, changeFilePath) f.assertEvents(subPath, changeFilePath)
} }