Add missing comma in DOCKER_CONFIG_KEYS list

Signed-off-by: Joffrey F <joffrey@docker.com>
This commit is contained in:
Joffrey F 2017-02-01 15:43:20 -08:00
parent 1f39b33357
commit 7e8958e6ca
2 changed files with 19 additions and 1 deletions

View File

@ -78,7 +78,7 @@ DOCKER_CONFIG_KEYS = [
'memswap_limit',
'mem_swappiness',
'net',
'oom_score_adj'
'oom_score_adj',
'pid',
'ports',
'privileged',

View File

@ -1748,6 +1748,24 @@ class ConfigTest(unittest.TestCase):
}
}
def test_merge_pid(self):
# Regression: https://github.com/docker/compose/issues/4184
base = {
'image': 'busybox',
'pid': 'host'
}
override = {
'labels': {'com.docker.compose.test': 'yes'}
}
actual = config.merge_service_dicts(base, override, V2_0)
assert actual == {
'image': 'busybox',
'pid': 'host',
'labels': {'com.docker.compose.test': 'yes'}
}
def test_external_volume_config(self):
config_details = build_config_details({
'version': '2',