tyler.durden/compose
1
0
Fork 0
mirror of https://github.com/docker/compose.git synced 2025-07-23 21:54:40 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1100 from docker/ecs-secrets-cleanup

Browse Source 
Remove unnecessary retry in ECS secrets test
This commit is contained in:
Nicolas De loof 2021-01-06 10:28:27 +01:00 committed by GitHub
commit 849fbed1ac
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tests/ecs-e2e/e2e-ecs_test.go
View File

@ -62,10 +62,6 @@ func TestSecrets(t *testing.T) {
t.Run("list secrets", func(t *testing.T) { t.Run("list secrets", func(t *testing.T) {
res := cmd.RunDockerCmd("secret", "list") res := cmd.RunDockerCmd("secret", "list")
if !strings.Contains(res.Stdout(), secretName) { // test sometimes fail, it seems things might need a bit of time on the AWS side, trying once morez
time.Sleep(1 * time.Second)
res = cmd.RunDockerCmd("secret", "list")
}
assert.Check(t, strings.Contains(res.Stdout(), secretName), res.Stdout()) assert.Check(t, strings.Contains(res.Stdout(), secretName), res.Stdout())
}) })
@ -91,7 +87,6 @@ func TestCompose(t *testing.T) {
var webURL, wordsURL, secretsURL string var webURL, wordsURL, secretsURL string
t.Run("compose ps", func(t *testing.T) { t.Run("compose ps", func(t *testing.T) {
res := c.RunDockerCmd("compose", "ps", "--project-name", stack) res := c.RunDockerCmd("compose", "ps", "--project-name", stack)
fmt.Println(strings.TrimSpace(res.Stdout()))
lines := strings.Split(strings.TrimSpace(res.Stdout()), "\n") lines := strings.Split(strings.TrimSpace(res.Stdout()), "\n")
assert.Equal(t, 5, len(lines)) assert.Equal(t, 5, len(lines))