tyler.durden/compose
1
0
Fork 0
mirror of https://github.com/docker/compose.git synced 2025-07-29 16:44:20 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix race condition in docker-compose run

Browse Source 
We shouldn't start the container before handing it off to dockerpty -
dockerpty will start it after attaching, which is the correct order.
Otherwise the container might exit before we attach to it, which can
lead to weird bugs.

Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
This commit is contained in:
Aanand Prasad 2015-05-15 12:16:24 +01:00
parent c8022457eb
commit 862971cffa
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
compose/cli/main.py
View File

@ -341,7 +341,6 @@ class TopLevelCommand(Command):
service.start_container(container) service.start_container(container)
print(container.name) print(container.name)
else: else:
service.start_container(container)
dockerpty.start(project.client, container.id, interactive=not options['-T']) dockerpty.start(project.client, container.id, interactive=not options['-T'])
exit_code = container.wait() exit_code = container.wait()
if options['--rm']: if options['--rm']: