From 869a0b8dd8285213855bdebd7c68fee611e97c2a Mon Sep 17 00:00:00 2001 From: Guillaume Tardif Date: Fri, 16 Oct 2020 16:47:13 +0200 Subject: [PATCH] Apply suggestions from code review Signed-off-by: Guillaume Tardif --- docs/aci-compose-features.md | 3 +-- docs/aci-container-features.md | 18 +++++++++--------- 2 files changed, 10 insertions(+), 11 deletions(-) diff --git a/docs/aci-compose-features.md b/docs/aci-compose-features.md index 785250f82..8626e9e5c 100644 --- a/docs/aci-compose-features.md +++ b/docs/aci-compose-features.md @@ -85,8 +85,7 @@ __Legend:__ ## Logs Container logs can be obtained for each container with `docker logs `. -The Docker ACI integration does not currently support aggregated logs for containers in a Compose application, -due to ACI not providing either aggregated logs for a container group, or log timestamps that can be easily used to reorder logs properly for display. +The Docker ACI integration does not currently support aggregated logs for containers in a Compose application, see https://github.com/docker/compose-cli/issues/803. ## Exposing ports diff --git a/docs/aci-container-features.md b/docs/aci-container-features.md index 99565a6c6..3f5688618 100644 --- a/docs/aci-container-features.md +++ b/docs/aci-container-features.md @@ -17,18 +17,18 @@ __Legend:__ | Flag |Map| Notes |-----------------------|---|---------------------------------| -| --cpus | ✓ | See [Container Resources](#container-resources) -| -d, --detach | ✓ | Detach from container logs when container starts. By default, the command line stays attached and follow container logs -| --domainname | ✓ | See [Exposing ports](#exposing-ports) -| --e, --env | ✓ | Sets environment variable -| --envFile | ✓ | Sets environment variable from and external file -| -l, --label | x | Unsupported in Docker ACI integration, due to limitations of ACI Tags -| -m, --memory | ✓ | See [Container Resources](#container-resources) +| --cpus | ✓ | See [Container Resources](#container-resources). +| -d, --detach | ✓ | Detach from container logs when container starts. By default, the command line stays attached and follow container logs. +| --domainname | ✓ | See [Exposing ports](#exposing-ports). +| --e, --env | ✓ | Sets environment variable. +| --envFile | ✓ | Sets environment variable from and external file. +| -l, --label | x | Unsupported in Docker ACI integration, due to limitations of ACI Tags. +| -m, --memory | ✓ | See [Container Resources](#container-resources). | --name | ✓ | Provide a name for the container. Name must be unique withing the ACI resource group. a name is generated by default. | -p, --publish | ✓ | See [Exposing ports](#exposing-ports). Only symetrical port mapping is supported in ACI. | --restart | ✓ | Restart policy, must be one of: `any`, `none`, `on-failure`. -| --rm | x | Not supported as [ACI does not support auto-delete containers](https://feedback.azure.com/forums/602224-azure-container-instances/suggestions/34066633-support-auto-delete-of-aci-when-container-exits-no) -| -v, --volume | ✓ | See [Persistent Volumes](#persistent-volumes) +| --rm | x | Not supported as [ACI does not support auto-delete containers](https://feedback.azure.com/forums/602224-azure-container-instances/suggestions/34066633-support-auto-delete-of-aci-when-container-exits-no). +| -v, --volume | ✓ | See [Persistent Volumes](#persistent-volumes). ## Exposing ports