tyler.durden
/
compose
mirror of https://github.com/docker/compose.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Improve boolean warning message. 

Including examples of more boolean types, eg yes/N as it's not
always immediately clear that they are treated as booleans.

Signed-off-by: Mazz Mosley <mazz@houseofmnowster.com>
This commit is contained in:
Mazz Mosley 2015-10-07 14:59:08 +01:00
parent 627f1acdc4
commit 8efc39e616
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
compose/config/validation.py
View File

@ -57,9 +57,9 @@ def format_boolean_in_environment(instance):
"""
if isinstance(instance, bool):
log.warn(
"Warning: There is a boolean value, {0} in the 'environment' key.\n"
"Warning: There is a boolean value in the 'environment' key.\n"
"Environment variables can only be strings.\nPlease add quotes to any boolean values to make them string "
"(eg, '{0}').\nThis warning will become an error in a future release. \r\n".format(instance)
"(eg, 'True', 'yes', 'N').\nThis warning will become an error in a future release. \r\n"
)
return True

2
tests/unit/config/config_test.py
View File

@ -319,7 +319,7 @@ class ConfigTest(unittest.TestCase):
@mock.patch('compose.config.validation.log')
def test_logs_warning_for_boolean_in_environment(self, mock_logging):
expected_warning_msg = "Warning: There is a boolean value, True in the 'environment' key."
expected_warning_msg = "Warning: There is a boolean value in the 'environment' key."
config.load(
build_config_details(
{'web': {