From 9103215bf3c9731c271ba71452a94cde7b438fac Mon Sep 17 00:00:00 2001 From: Djordje Lukic Date: Wed, 5 Aug 2020 15:08:40 +0200 Subject: [PATCH] Don't return error if we can't parse the creds We just continue on to the next credentials --- aci/convert/registrycredentials.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/aci/convert/registrycredentials.go b/aci/convert/registrycredentials.go index 5b666e93b..0e12147a9 100644 --- a/aci/convert/registrycredentials.go +++ b/aci/convert/registrycredentials.go @@ -73,8 +73,10 @@ func getRegistryCredentials(project compose.Project, registryLoader registryConf var registryCreds []containerinstance.ImageRegistryCredential for name, oneCred := range allCreds { parsedURL, err := url.Parse(name) + // Credentials can contain some garbage, we don't return the error here + // because we don't care about these garbage creds. if err != nil { - return nil, err + continue } hostname := parsedURL.Host