tilt: enable errcheck on tests (#2877)

This commit is contained in:
Matt Landis 2020-01-30 14:23:36 -05:00 committed by Nicolas De loof
parent 00b3caecbb
commit 92c6a65a03
1 changed files with 12 additions and 3 deletions

View File

@ -12,6 +12,8 @@ import (
"testing" "testing"
"time" "time"
"github.com/stretchr/testify/require"
"github.com/stretchr/testify/assert" "github.com/stretchr/testify/assert"
"github.com/windmilleng/tilt/internal/dockerignore" "github.com/windmilleng/tilt/internal/dockerignore"
@ -95,7 +97,8 @@ func TestGitBranchSwitch(t *testing.T) {
} }
if i != 0 { if i != 0 {
os.RemoveAll(dir) err := os.RemoveAll(dir)
require.NoError(t, err)
} }
} }
@ -313,7 +316,12 @@ func TestWatchBrokenLink(t *testing.T) {
if err != nil { if err != nil {
t.Fatal(err) t.Fatal(err)
} }
defer newRoot.TearDown() defer func() {
err := newRoot.TearDown()
if err != nil {
fmt.Printf("error tearing down temp dir: %v\n", err)
}
}()
link := filepath.Join(newRoot.Path(), "brokenLink") link := filepath.Join(newRoot.Path(), "brokenLink")
missingFile := filepath.Join(newRoot.Path(), "missingFile") missingFile := filepath.Join(newRoot.Path(), "missingFile")
@ -323,7 +331,8 @@ func TestWatchBrokenLink(t *testing.T) {
} }
f.watch(newRoot.Path()) f.watch(newRoot.Path())
os.Remove(link) err = os.Remove(link)
require.NoError(t, err)
f.assertEvents(link) f.assertEvents(link)
} }