tyler.durden/compose
1
0
Fork 0
mirror of https://github.com/docker/compose.git synced 2025-07-27 07:34:10 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #956 from docker/fix-port-collision

Browse Source 
Avoid port collision with compose up test
This commit is contained in:
Nicolas De loof 2020-11-24 18:20:41 +01:00 committed by GitHub
commit 9e1de51f82
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
local/e2e/backend_test.go
View File

@ -23,6 +23,8 @@ import (
"testing" "testing"
"time" "time"
"gotest.tools/v3/assert"
"gotest.tools/v3/assert/cmp"
"gotest.tools/v3/icmd" "gotest.tools/v3/icmd"
"gotest.tools/v3/poll" "gotest.tools/v3/poll"
@ -78,7 +80,7 @@ func TestLocalBackendRun(t *testing.T) {
}) })
t.Run("run with ports", func(t *testing.T) { t.Run("run with ports", func(t *testing.T) {
res := c.RunDockerCmd("run", "-d", "-p", "8080:80", "nginx") res := c.RunDockerCmd("run", "-d", "-p", "80", "nginx")
containerName := strings.TrimSpace(res.Combined()) containerName := strings.TrimSpace(res.Combined())
t.Cleanup(func() { t.Cleanup(func() {
_ = c.RunDockerOrExitError("rm", "-f", containerName) _ = c.RunDockerOrExitError("rm", "-f", containerName)
@ -86,7 +88,7 @@ func TestLocalBackendRun(t *testing.T) {
res = c.RunDockerCmd("inspect", containerName) res = c.RunDockerCmd("inspect", containerName)
res.Assert(t, icmd.Expected{Out: `"Status": "running"`}) res.Assert(t, icmd.Expected{Out: `"Status": "running"`})
res = c.RunDockerCmd("ps") res = c.RunDockerCmd("ps")
res.Assert(t, icmd.Expected{Out: "0.0.0.0:8080->80/tcp"}) assert.Assert(t, cmp.Regexp(`0\.0\.0\.0:\d*->80/tcp`, res.Stdout()))
}) })
t.Run("run with volume", func(t *testing.T) { t.Run("run with volume", func(t *testing.T) {