tyler.durden/compose
1
0
Fork 0
mirror of https://github.com/docker/compose.git synced 2025-07-20 20:24:30 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #9640 from glours/fix-close-network-name-issue

Browse Source 
Fix issue with close networks name on up and down command
This commit is contained in:
Guillaume Lours 2022-07-13 10:46:13 +02:00 committed by GitHub
commit 9fdd7d81b3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 16 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
pkg/compose/create.go
View File

@ -1041,7 +1041,14 @@ func (s *composeService) ensureNetwork(ctx context.Context, n types.NetworkConfi
if err != nil { if err != nil {
return err return err
} }
if len(networks) == 0 { networkNotFound := true
for _, net := range networks {
if net.Name == n.Name {
networkNotFound = false
break
}
}
if networkNotFound {
if n.External.External { if n.External.External {
if n.Driver == "overlay" { if n.Driver == "overlay" {
// Swarm nodes do not register overlay networks that were // Swarm nodes do not register overlay networks that were

14
pkg/compose/down.go
View File

@ -163,14 +163,16 @@ func (s *composeService) removeNetwork(ctx context.Context, name string, w progr
var removed int var removed int
for _, net := range networks { for _, net := range networks {
if err := s.apiClient().NetworkRemove(ctx, net.ID); err != nil { if net.Name == name {
if errdefs.IsNotFound(err) { if err := s.apiClient().NetworkRemove(ctx, net.ID); err != nil {
continue if errdefs.IsNotFound(err) {
continue
}
w.Event(progress.ErrorEvent(eventName))
return errors.Wrapf(err, fmt.Sprintf("failed to remove network %s", name))
} }
w.Event(progress.ErrorEvent(eventName)) removed++
return errors.Wrapf(err, fmt.Sprintf("failed to remove network %s", name))
} }
removed++
} }
if removed == 0 { if removed == 0 {