From b4b221f6a3d57f3af46d7be735bec624363a4465 Mon Sep 17 00:00:00 2001
From: Evan Shaw <evan@vendhq.com>
Date: Tue, 14 Feb 2017 10:52:57 +1300
Subject: [PATCH] Update to address code review feedback

Signed-off-by: Evan Shaw <evan@vendhq.com>
---
 compose/cli/main.py | 2 +-
 compose/project.py  | 4 ++--
 compose/service.py  | 7 ++++++-
 3 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/compose/cli/main.py b/compose/cli/main.py
index 423e214e9..ae6b0ac69 100644
--- a/compose/cli/main.py
+++ b/compose/cli/main.py
@@ -607,7 +607,7 @@ class TopLevelCommand(object):
         self.project.pull(
             service_names=options['SERVICE'],
             ignore_pull_failures=options.get('--ignore-pull-failures'),
-            in_parallel=options.get('--parallel')
+            parallel_pull=options.get('--parallel')
         )
 
     def push(self, options):
diff --git a/compose/project.py b/compose/project.py
index c08fbc362..5c21f3bf0 100644
--- a/compose/project.py
+++ b/compose/project.py
@@ -454,10 +454,10 @@ class Project(object):
 
         return plans
 
-    def pull(self, service_names=None, ignore_pull_failures=False, in_parallel=False):
+    def pull(self, service_names=None, ignore_pull_failures=False, parallel_pull=False):
         services = self.get_services(service_names, include_deps=False)
 
-        if in_parallel:
+        if parallel_pull:
             def pull_service(service):
                 service.pull(ignore_pull_failures, True)
 
diff --git a/compose/service.py b/compose/service.py
index 0eadadfb9..5305a151a 100644
--- a/compose/service.py
+++ b/compose/service.py
@@ -2,6 +2,7 @@ from __future__ import absolute_import
 from __future__ import unicode_literals
 
 import logging
+import os
 import re
 import sys
 from collections import namedtuple
@@ -896,7 +897,11 @@ class Service(object):
             log.info('Pulling %s (%s%s%s)...' % (self.name, repo, separator, tag))
         try:
             output = self.client.pull(repo, tag=tag, stream=True)
-            if not silent:
+            if silent:
+                with open(os.devnull, 'w') as devnull:
+                    return progress_stream.get_digest_from_pull(
+                        stream_output(output, devnull))
+            else:
                 return progress_stream.get_digest_from_pull(
                     stream_output(output, sys.stdout))
         except (StreamOutputError, NotFound) as e: