Fix merging of logging options in v1 config.

Signed-off-by: Daniel Nephin <dnephin@docker.com>
This commit is contained in:
Daniel Nephin 2016-03-01 11:42:19 -05:00
parent fc99c7ee19
commit b726f508a6
2 changed files with 20 additions and 0 deletions

View File

@ -88,6 +88,8 @@ ALLOWED_KEYS = DOCKER_CONFIG_KEYS + [
'build', 'build',
'container_name', 'container_name',
'dockerfile', 'dockerfile',
'log_driver',
'log_opt',
'logging', 'logging',
'network_mode', 'network_mode',
] ]

View File

@ -1248,6 +1248,24 @@ class ConfigTest(unittest.TestCase):
} }
} }
def test_merge_logging_v1(self):
base = {
'image': 'alpine:edge',
'log_driver': 'something',
'log_opt': {'foo': 'three'},
}
override = {
'image': 'alpine:edge',
'command': 'true',
}
actual = config.merge_service_dicts(base, override, V1)
assert actual == {
'image': 'alpine:edge',
'log_driver': 'something',
'log_opt': {'foo': 'three'},
'command': 'true',
}
def test_external_volume_config(self): def test_external_volume_config(self):
config_details = build_config_details({ config_details = build_config_details({
'version': '2', 'version': '2',