invoke browser with Run rather than Start, to get errors (on wsl no interop setup, and more generally if the browser app returns an error)

Signed-off-by: guillaume.tardif <guillaume.tardif@gmail.com>
This commit is contained in:
guillaume.tardif 2020-09-02 17:31:04 +02:00
parent 909be662ee
commit bb58290eeb

View File

@ -102,13 +102,13 @@ func openbrowser(address string) error {
switch runtime.GOOS { switch runtime.GOOS {
case "linux": case "linux":
if isWsl() { if isWsl() {
return exec.Command("wslview", address).Start() return exec.Command("wslview", address).Run()
} }
return exec.Command("xdg-open", address).Start() return exec.Command("xdg-open", address).Run()
case "windows": case "windows":
return exec.Command("rundll32", "url.dll,FileProtocolHandler", address).Start() return exec.Command("rundll32", "url.dll,FileProtocolHandler", address).Run()
case "darwin": case "darwin":
return exec.Command("open", address).Start() return exec.Command("open", address).Run()
default: default:
return fmt.Errorf("unsupported platform") return fmt.Errorf("unsupported platform")
} }