tyler.durden/compose
1
0
Fork 0
mirror of https://github.com/docker/compose.git synced 2025-10-31 19:24:21 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #957 from docker/linter-dependencies-local

Browse Source 
Fix some linter issues when running `make lint`
This commit is contained in:
Nicolas De loof 2020-11-24 09:00:04 +01:00 committed by GitHub
commit bdde820989
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
local/dependencies.go
View File

@ -28,8 +28,10 @@ import (
"golang.org/x/sync/errgroup" "golang.org/x/sync/errgroup"
) )
// ServiceStatus indicates the status of a service
type ServiceStatus int type ServiceStatus int
// Services status flags
const ( const (
ServiceStopped ServiceStatus = iota ServiceStopped ServiceStatus = iota
ServiceStarted ServiceStarted
@ -76,11 +78,13 @@ func run(ctx context.Context, graph *Graph, eg *errgroup.Group, nodes []*Vertex,
return nil return nil
} }
// Graph represents project as service dependencies
type Graph struct { type Graph struct {
Vertices map[string]*Vertex Vertices map[string]*Vertex
lock sync.RWMutex lock sync.RWMutex
} }
// Vertex represents a service in the dependencies structure
type Vertex struct { type Vertex struct {
Key string Key string
Service types.ServiceConfig Service types.ServiceConfig
@ -89,6 +93,7 @@ type Vertex struct {
Parents map[string]*Vertex Parents map[string]*Vertex
} }
// GetParents returns a slice with the parent vertexes of the current Vertex
func (v *Vertex) GetParents() []*Vertex { func (v *Vertex) GetParents() []*Vertex {
var res []*Vertex var res []*Vertex
for _, p := range v.Parents { for _, p := range v.Parents {
@ -97,6 +102,7 @@ func (v *Vertex) GetParents() []*Vertex {
return res return res
} }
// NewGraph returns the dependency graph of the services
func NewGraph(services types.Services) *Graph { func NewGraph(services types.Services) *Graph {
graph := &Graph{ graph := &Graph{
lock: sync.RWMutex{}, lock: sync.RWMutex{},
@ -109,14 +115,14 @@ func NewGraph(services types.Services) *Graph {
for _, s := range services { for _, s := range services {
for _, name := range s.GetDependencies() { for _, name := range s.GetDependencies() {
graph.AddEdge(s.Name, name) _ = graph.AddEdge(s.Name, name)
} }
} }
return graph return graph
} }
// We then create a constructor function for the Vertex // NewVertex is the constructor function for the Vertex
func NewVertex(key string, service types.ServiceConfig) *Vertex { func NewVertex(key string, service types.ServiceConfig) *Vertex {
return &Vertex{ return &Vertex{
Key: key, Key: key,
@ -127,6 +133,7 @@ func NewVertex(key string, service types.ServiceConfig) *Vertex {
} }
} }
// AddVertex adds a vertex to the Graph
func (g *Graph) AddVertex(key string, service types.ServiceConfig) { func (g *Graph) AddVertex(key string, service types.ServiceConfig) {
g.lock.Lock() g.lock.Lock()
defer g.lock.Unlock() defer g.lock.Unlock()
@ -135,6 +142,7 @@ func (g *Graph) AddVertex(key string, service types.ServiceConfig) {
g.Vertices[key] = v g.Vertices[key] = v
} }
// AddEdge adds a relationship of dependency between vertexes `source` and `destination`
func (g *Graph) AddEdge(source string, destination string) error { func (g *Graph) AddEdge(source string, destination string) error {
g.lock.Lock() g.lock.Lock()
defer g.lock.Unlock() defer g.lock.Unlock()
@ -160,6 +168,7 @@ func (g *Graph) AddEdge(source string, destination string) error {
return nil return nil
} }
// Leaves returns the slice of leaves of the graph
func (g *Graph) Leaves() []*Vertex { func (g *Graph) Leaves() []*Vertex {
g.lock.Lock() g.lock.Lock()
defer g.lock.Unlock() defer g.lock.Unlock()
@ -174,12 +183,14 @@ func (g *Graph) Leaves() []*Vertex {
return res return res
} }
// UpdateStatus updates the status of a certain vertex
func (g *Graph) UpdateStatus(key string, status ServiceStatus) { func (g *Graph) UpdateStatus(key string, status ServiceStatus) {
g.lock.Lock() g.lock.Lock()
defer g.lock.Unlock() defer g.lock.Unlock()
g.Vertices[key].Status = status g.Vertices[key].Status = status
} }
// FilterChildren returns children of a certain vertex that are in a certain status
func (g *Graph) FilterChildren(key string, status ServiceStatus) []*Vertex { func (g *Graph) FilterChildren(key string, status ServiceStatus) []*Vertex {
g.lock.Lock() g.lock.Lock()
defer g.lock.Unlock() defer g.lock.Unlock()
@ -196,6 +207,7 @@ func (g *Graph) FilterChildren(key string, status ServiceStatus) []*Vertex {
return res return res
} }
// HasCycles detects cycles in the graph
func (g *Graph) HasCycles() (bool, error) { func (g *Graph) HasCycles() (bool, error) {
discovered := []string{} discovered := []string{}
finished := []string{} finished := []string{}