tyler.durden
/
compose
mirror of https://github.com/docker/compose.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

improve lb security groups parsing 

Signed-off-by: aiordache <anca.iordache@docker.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
This commit is contained in:
aiordache 2020-06-05 11:34:02 +02:00 committed by Nicolas De Loof
parent dad36e09f9
commit c04950cdac
No known key found for this signature in database
GPG Key ID: 9858809D6F8F6E7E
1 changed files with 9 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
ecs/pkg/amazon/cloudformation.go
View File

@ -186,28 +186,22 @@ func (c client) Convert(project *compose.Project) (*cloudformation.Template, err
}
func (c client) getLoadBalancerType(project *compose.Project, networks map[string]string) (string, []string) {
// check what type of load balancer to create, we asssume by default application type
loadBalancerType := elbv2.LoadBalancerTypeEnumApplication
albSecurityGroups := []string{}
for _, service := range project.Services {
if len(service.Ports) == 0 {
continue
}
for _, port := range service.Ports {
if port.Published != 80 && port.Published != 443 {
return elbv2.LoadBalancerTypeEnumNetwork, []string{}
}
}
serviceSecurityGroups := []string{}
for net := range service.Networks {
serviceSecurityGroups = append(serviceSecurityGroups, networks[net])
}
albSecurityGroups = append(albSecurityGroups, serviceSecurityGroups...)
albSecurityGroups = uniqueStrings(albSecurityGroups)
}
return loadBalancerType, albSecurityGroups
albSecurityGroups := []string{}
for _, network := range project.Networks {
if !network.Internal {
albSecurityGroups = append(albSecurityGroups, networks[network.Name])
}
}
albSecurityGroups = uniqueStrings(albSecurityGroups)
return elbv2.LoadBalancerTypeEnumApplication, albSecurityGroups
}
func (c client) createLoadBalancer(project *compose.Project, template *cloudformation.Template, loadBalancerType string, securityGroups []string) string {