From 998dbf79f96879abbf2ed6af446364e2b949fa71 Mon Sep 17 00:00:00 2001 From: Guillaume Tardif Date: Thu, 6 May 2021 09:40:58 +0200 Subject: [PATCH] Avoid using for variable in go func, as this creates race conditions Signed-off-by: Guillaume Tardif --- local/compose/convergence.go | 1 + 1 file changed, 1 insertion(+) diff --git a/local/compose/convergence.go b/local/compose/convergence.go index d394ad628..a46ff0657 100644 --- a/local/compose/convergence.go +++ b/local/compose/convergence.go @@ -147,6 +147,7 @@ func getContainerProgressName(container moby.Container) string { func (s *composeService) waitDependencies(ctx context.Context, project *types.Project, service types.ServiceConfig) error { eg, _ := errgroup.WithContext(ctx) for dep, config := range service.DependsOn { + dep, config := dep, config eg.Go(func() error { ticker := time.NewTicker(500 * time.Millisecond) defer ticker.Stop()