tyler.durden
/
compose
mirror of https://github.com/docker/compose.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3457 from dnephin/fix_versions_script 

Skip invalid git tags in versions.py
This commit is contained in:
Joffrey F 2016-05-12 13:52:20 -07:00
parent 72f6a5c8d3 4bf5271ae2
commit c9fe8920c9
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
script/test/versions.py
View File

@ -28,6 +28,7 @@ from __future__ import unicode_literals
import argparse import argparse
import itertools import itertools
import operator import operator
import sys
from collections import namedtuple from collections import namedtuple
import requests import requests
@ -103,6 +104,14 @@ def get_default(versions):
return version return version
def get_versions(tags):
for tag in tags:
try:
yield Version.parse(tag['name'])
except ValueError:
print("Skipping invalid tag: {name}".format(**tag), file=sys.stderr)
def get_github_releases(project): def get_github_releases(project):
"""Query the Github API for a list of version tags and return them in """Query the Github API for a list of version tags and return them in
sorted order. sorted order.
@ -112,7 +121,7 @@ def get_github_releases(project):
url = '{}/{}/tags'.format(GITHUB_API, project) url = '{}/{}/tags'.format(GITHUB_API, project)
response = requests.get(url) response = requests.get(url)
response.raise_for_status() response.raise_for_status()
versions = [Version.parse(tag['name']) for tag in response.json()] versions = get_versions(response.json())
return sorted(versions, reverse=True, key=operator.attrgetter('order')) return sorted(versions, reverse=True, key=operator.attrgetter('order'))