From cb74f7924e5bf89e67f55229c04fe67b2137643e Mon Sep 17 00:00:00 2001 From: Nicolas De Loof Date: Mon, 15 Jun 2020 17:48:56 +0200 Subject: [PATCH] Don't define service resource name if we do, CloudFormation can't update resource and changeset fail with "CloudFormation cannot update a stack when a custom-named resource requires replacing" Signed-off-by: Nicolas De Loof --- ecs/pkg/amazon/backend/cloudformation.go | 1 - ecs/pkg/amazon/sdk/sdk.go | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/ecs/pkg/amazon/backend/cloudformation.go b/ecs/pkg/amazon/backend/cloudformation.go index 5cdbcdc29..c27f65317 100644 --- a/ecs/pkg/amazon/backend/cloudformation.go +++ b/ecs/pkg/amazon/backend/cloudformation.go @@ -193,7 +193,6 @@ func (b Backend) Convert(project *types.Project) (*cloudformation.Template, erro }, }, SchedulingStrategy: ecsapi.SchedulingStrategyReplica, - ServiceName: service.Name, ServiceRegistries: []ecs.Service_ServiceRegistry{serviceRegistry}, Tags: []tags.Tag{ { diff --git a/ecs/pkg/amazon/sdk/sdk.go b/ecs/pkg/amazon/sdk/sdk.go index 3f0ed9297..4d8828697 100644 --- a/ecs/pkg/amazon/sdk/sdk.go +++ b/ecs/pkg/amazon/sdk/sdk.go @@ -182,6 +182,7 @@ func (s sdk) CreateStack(ctx context.Context, name string, template *cf.Template }) return err } + func (s sdk) WaitStackComplete(ctx context.Context, name string, operation int) error { input := &cloudformation.DescribeStacksInput{ StackName: aws.String(name),