diff --git a/Makefile b/Makefile index 33d0161e1..7f6f5fa1a 100644 --- a/Makefile +++ b/Makefile @@ -104,6 +104,12 @@ build-aci-sidecar: ## build aci sidecar image locally and tag it with make buil publish-aci-sidecar: build-aci-sidecar ## build & publish aci sidecar image with make publish-aci-sidecar tag=0.1 docker pull docker/aci-hostnames-sidecar:$(tag) && echo "Failure: Tag already exists" || docker push docker/aci-hostnames-sidecar:$(tag) +build-ecs-search-sidecar: ## build ecs search sidecar image locally and tag it with make build-ecs-search-sidecar tag=0.1 + docker build -t docker/ecs-searchdomain-sidecar:$(tag) ecs/resolv + +publish-ecs-search-sidecar: build-ecs-search-sidecar ## build & publish ecs search sidecar image with make publish-ecs-search-sidecar tag=0.1 + docker pull docker/ecs-searchdomain-sidecar:$(tag) && echo "Failure: Tag already exists" || docker push docker/ecs-searchdomain-sidecar:$(tag) + clean-aci-e2e: ## Make sure no ACI tests are currently runnnig in the CI when invoking this. Delete ACI E2E tests resources that might have leaked when ctrl-C E2E tests. az group list | jq '.[].name' | grep E2E-Test | xargs -n1 az group delete -y --no-wait -g diff --git a/ecs/convert.go b/ecs/convert.go index aef6007f4..c20877fe7 100644 --- a/ecs/convert.go +++ b/ecs/convert.go @@ -37,7 +37,7 @@ import ( ) const secretsInitContainerImage = "docker/ecs-secrets-sidecar" -const searchDomainInitContainerImage = "docker/ecs-searchdomain-sidecar" +const searchDomainInitContainerImage = "docker/ecs-searchdomain-sidecar:1.0" func (b *ecsAPIService) createTaskDefinition(project *types.Project, service types.ServiceConfig, resources awsResources) (*ecs.TaskDefinition, error) { cpu, mem, err := toLimits(service) diff --git a/ecs/testdata/simple/simple-cloudformation-conversion.golden b/ecs/testdata/simple/simple-cloudformation-conversion.golden index fa63524d9..d064cdd81 100644 --- a/ecs/testdata/simple/simple-cloudformation-conversion.golden +++ b/ecs/testdata/simple/simple-cloudformation-conversion.golden @@ -234,7 +234,7 @@ "TestSimpleConvert.local" ], "Essential": "false", - "Image": "docker/ecs-searchdomain-sidecar", + "Image": "docker/ecs-searchdomain-sidecar:1.0", "LogConfiguration": { "LogDriver": "awslogs", "Options": {