tyler.durden/compose
1
0
Fork 0
mirror of https://github.com/docker/compose.git synced 2025-05-30 11:20:25 +02:00
Code Issues Packages Projects Releases Wiki Activity

ignore: add Go umask files to ephemeral set (#5740)

Browse Source 
When creating files in Go, the stdlib will create (and then rapidly
delete) files ending with `-go-tmp-umask` to determine the umask
to use for permission purposes.

This can cause trouble with Live Update because the files tend to
vanish underneath it, for example.

Fixes #5117.
This commit is contained in:
Milas Bowman 2022-04-27 16:42:51 -04:00 committed by Milas Bowman
parent 12de97b8d1
commit dd5ea044bb
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
pkg/watch/ephemeral.go
View File

@ -5,8 +5,8 @@ import (
"github.com/tilt-dev/tilt/pkg/model" "github.com/tilt-dev/tilt/pkg/model"
) )
// Filter out spurious changes that we don't want to rebuild on, like IDE // EphemeralPathMatcher filters out spurious changes that we don't want to
// temp/lock files. // rebuild on, like IDE temp/lock files.
// //
// This isn't an ideal solution. In an ideal world, the user would put // This isn't an ideal solution. In an ideal world, the user would put
// everything to ignore in their tiltignore/dockerignore files. This is a // everything to ignore in their tiltignore/dockerignore files. This is a
@ -29,12 +29,17 @@ func initEphemeralPathMatcher() model.PathMatcher {
// files, but it doesn't have the "incrememnting" character problem mentioned // files, but it doesn't have the "incrememnting" character problem mentioned
// above // above
katePatterns := []string{"**/.*.kate-swp"} katePatterns := []string{"**/.*.kate-swp"}
// go stdlib creates tmpfiles to determine umask for setting permissions
// during file creation; they are then immediately deleted
// https://github.com/golang/go/blob/0b5218cf4e3e5c17344ea113af346e8e0836f6c4/src/cmd/go/internal/work/exec.go#L1764
goPatterns := []string{"**/*-go-tmp-umask"}
allPatterns := []string{} allPatterns := []string{}
allPatterns = append(allPatterns, golandPatterns...) allPatterns = append(allPatterns, golandPatterns...)
allPatterns = append(allPatterns, emacsPatterns...) allPatterns = append(allPatterns, emacsPatterns...)
allPatterns = append(allPatterns, vimPatterns...) allPatterns = append(allPatterns, vimPatterns...)
allPatterns = append(allPatterns, katePatterns...) allPatterns = append(allPatterns, katePatterns...)
allPatterns = append(allPatterns, goPatterns...)
matcher, err := dockerignore.NewDockerPatternMatcher("/", allPatterns) matcher, err := dockerignore.NewDockerPatternMatcher("/", allPatterns)
if err != nil { if err != nil {