tyler.durden
/
compose
mirror of https://github.com/docker/compose.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1098 from gtardif/debug_info_flaky_ecs_tests 

Fix ECS flaky test and add bettre debug info in assertions
This commit is contained in:
Nicolas De loof 2021-01-05 17:46:12 +01:00 committed by GitHub
parent 92eeb624ea e98a790ce9
commit e63dc29b9f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
tests/ecs-e2e/e2e-ecs_test.go
View File

@ -57,23 +57,27 @@ func TestSecrets(t *testing.T) {
err := ioutil.WriteFile(secretFile, []byte("pass1"), 0644) err := ioutil.WriteFile(secretFile, []byte("pass1"), 0644)
assert.Check(t, err == nil) assert.Check(t, err == nil)
res := cmd.RunDockerCmd("secret", "create", secretName, secretFile) res := cmd.RunDockerCmd("secret", "create", secretName, secretFile)
assert.Check(t, strings.Contains(res.Stdout(), secretName)) assert.Check(t, strings.Contains(res.Stdout(), secretName), res.Stdout())
}) })
t.Run("list secrets", func(t *testing.T) { t.Run("list secrets", func(t *testing.T) {
res := cmd.RunDockerCmd("secret", "list") res := cmd.RunDockerCmd("secret", "list")
assert.Check(t, strings.Contains(res.Stdout(), secretName)) if !strings.Contains(res.Stdout(), secretName) { // test sometimes fail, it seems things might need a bit of time on the AWS side, trying once morez
time.Sleep(1 * time.Second)
res = cmd.RunDockerCmd("secret", "list")
}
assert.Check(t, strings.Contains(res.Stdout(), secretName), res.Stdout())
}) })
t.Run("inspect secret", func(t *testing.T) { t.Run("inspect secret", func(t *testing.T) {
res := cmd.RunDockerCmd("secret", "inspect", secretName) res := cmd.RunDockerCmd("secret", "inspect", secretName)
assert.Check(t, strings.Contains(res.Stdout(), `"Name": "`+secretName+`"`)) assert.Check(t, strings.Contains(res.Stdout(), `"Name": "`+secretName+`"`), res.Stdout())
}) })
t.Run("rm secret", func(t *testing.T) { t.Run("rm secret", func(t *testing.T) {
cmd.RunDockerCmd("secret", "rm", secretName) cmd.RunDockerCmd("secret", "rm", secretName)
res := cmd.RunDockerCmd("secret", "list") res := cmd.RunDockerCmd("secret", "list")
assert.Check(t, !strings.Contains(res.Stdout(), secretName)) assert.Check(t, !strings.Contains(res.Stdout(), secretName), res.Stdout())
}) })
} }