Merge pull request #4232 from shin-/attachable_networks

Make created networks attachable for file format >=2.1
This commit is contained in:
Joffrey F 2016-12-16 13:06:57 -08:00 committed by GitHub
commit ea7b565009
2 changed files with 6 additions and 3 deletions

View File

@ -6,6 +6,7 @@ import logging
from docker.errors import NotFound from docker.errors import NotFound
from docker.types import IPAMConfig from docker.types import IPAMConfig
from docker.types import IPAMPool from docker.types import IPAMPool
from docker.utils import version_gte
from .config import ConfigurationError from .config import ConfigurationError
@ -72,6 +73,7 @@ class Network(object):
internal=self.internal, internal=self.internal,
enable_ipv6=self.enable_ipv6, enable_ipv6=self.enable_ipv6,
labels=self.labels, labels=self.labels,
attachable=version_gte(self.client._version, '1.24') or None
) )
def remove(self): def remove(self):

View File

@ -928,6 +928,7 @@ class CLITestCase(DockerClientTestCase):
assert foo_container.get('HostConfig.NetworkMode') == \ assert foo_container.get('HostConfig.NetworkMode') == \
'container:{}'.format(bar_container.id) 'container:{}'.format(bar_container.id)
@v3_only()
def test_up_with_healthcheck(self): def test_up_with_healthcheck(self):
def wait_on_health_status(container, status): def wait_on_health_status(container, status):
def condition(): def condition():