tyler.durden/compose
1
0
Fork 0
mirror of https://github.com/docker/compose.git synced 2025-07-26 23:24:05 +02:00
Code Issues Packages Projects Releases Wiki Activity

make sure the post_start hooks fails

Browse Source 
before we were assuming the container will be close before the post_start will be executed

Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
This commit is contained in:
Guillaume Lours 2025-06-30 12:20:50 +02:00 committed by Nicolas De loof
parent 3553aa26a6
commit f613379373
2 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/e2e/fixtures/hooks/poststart/compose-error.yaml
View File

@ -1,6 +1,6 @@
services: services:
test: test:
image: alpine image: nginx
post_start: post_start:
- command: sh -c 'echo env' - command: sh -c 'command in error'

3
pkg/e2e/hooks_test.go
View File

@ -33,8 +33,7 @@ func TestPostStartHookInError(t *testing.T) {
res := c.RunDockerComposeCmdNoCheck(t, "-f", "fixtures/hooks/poststart/compose-error.yaml", "--project-name", projectName, "up", "-d") res := c.RunDockerComposeCmdNoCheck(t, "-f", "fixtures/hooks/poststart/compose-error.yaml", "--project-name", projectName, "up", "-d")
res.Assert(t, icmd.Expected{ExitCode: 1}) res.Assert(t, icmd.Expected{ExitCode: 1})
assert.Assert(t, strings.Contains(res.Combined(), "Error response from daemon: container"), res.Combined()) assert.Assert(t, strings.Contains(res.Combined(), "test hook exited with status 127"), res.Combined())
assert.Assert(t, strings.Contains(res.Combined(), "is not running"), res.Combined())
} }
func TestPostStartHookSuccess(t *testing.T) { func TestPostStartHookSuccess(t *testing.T) {