diff --git a/internal/experimental/experimental.go b/internal/experimental/experimental.go index d69609d97..253c0a49a 100644 --- a/internal/experimental/experimental.go +++ b/internal/experimental/experimental.go @@ -71,10 +71,6 @@ func (s *State) NavBar() bool { return s.determineFeatureState("ComposeNav") } -func (s *State) AutoFileShares() bool { - return s.determineFeatureState("ComposeAutoFileShares") -} - func (s *State) determineFeatureState(name string) bool { if s == nil || !s.active || s.desktopValues == nil { return false diff --git a/pkg/compose/desktop.go b/pkg/compose/desktop.go index 5e7fb8fea..a2ffb2757 100644 --- a/pkg/compose/desktop.go +++ b/pkg/compose/desktop.go @@ -33,12 +33,12 @@ func (s *composeService) SetExperiments(experiments *experimental.State) { } func (s *composeService) manageDesktopFileSharesEnabled(ctx context.Context) bool { - // there's some slightly redundancy here to avoid fetching the config if - // we can already tell the feature state - in practice, we - if !s.isDesktopIntegrationActive() || !s.experiments.AutoFileShares() { + if !s.isDesktopIntegrationActive() { return false } + // synchronized file share support in Docker Desktop is dependent upon + // a variety of factors (settings, OS, etc), which this endpoint abstracts fileSharesConfig, err := s.desktopCli.GetFileSharesConfig(ctx) if err != nil { logrus.Debugf("Failed to retrieve file shares config: %v", err)