75 Commits

Author SHA1 Message Date
Guillaume Tardif
a09983b474 Do not send metrics for help commands
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-08 14:47:31 +02:00
Guillaume Tardif
0d3f7186c5 Hardcoded list of commands and simplified metrics gathering.
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-08 11:59:12 +02:00
Guillaume Tardif
9ad06e55b5 E2e test on metrics
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-07 10:11:46 +02:00
Guillaume Tardif
a1bb2d5abe Allow docker context ls —formatter {{json.}} to not delegate to Moby and include context type in the json
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-06 18:00:35 +02:00
Guillaume Tardif
97576db803
Merge pull request #689 from ulyssessouza/json-out
Add json output format to several commands
2020-10-05 10:30:30 +02:00
Guillaume Tardif
6d0f7f399f Fix regression: let users login to local registry (no '.' In registry name)
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-02 13:54:59 +02:00
Ulysses Souza
8961805412 Add json output format to several commands
- docker context ls
- docker ps
- docker compose ls
- docker compose ps
- docker secret ls
- docker volume ls
- docker version

Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-10-01 15:41:18 +02:00
Guillaume Tardif
b8968e83cd Do not fail when constructing error message for commands not implemented. Use metrics GetCommand() the is already used 3 lines above for metrics tracking.
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-30 10:49:14 +02:00
Chris Crone
d154c41586 Update copyright
Signed-off-by: Chris Crone <christopher.crone@docker.com>
2020-09-22 12:13:00 +02:00
Guillaume Tardif
17bda79ca1 Changing e2e test PATH to make windows tests pass
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-17 17:13:05 +02:00
Guillaume Tardif
9c6aead797 Allow running commands with HOME=“”.
Do not try to create ~/.docker before using CONFIG_DIR. HOME=“” will result in trying to use a relative .docker folder as default config folder, and if we cannot create the context store for any reason, try delegate to Moby CLI.

Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-17 09:08:17 +02:00
Guillaume Tardif
2ce4e98d88 In version, replace “Azure integration” version info by “Cloud integration”
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-11 17:29:40 +02:00
Guillaume Tardif
ad5c465bd1
Merge pull request #485 from docker/repo-rename
Rename docker/api -> docker/compose-cli
2020-08-25 15:58:51 +02:00
Ulysses Souza
59f7d7cd00 Redirect user from plugin usage to integrated ECS
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-08-24 19:29:10 +02:00
Guillaume Tardif
981665b02c Better renaming
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-08-24 16:09:20 +02:00
Guillaume Tardif
2bac8cf94e Fix linter
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-08-21 21:28:15 +02:00
Guillaume Tardif
da6334f415 Renaming, expect commands to succeed by default (removed a bunch of res.Assert(success) )
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-08-21 18:45:38 +02:00
Chris Crone
4c6280b0e9 Rename docker/api -> docker/compose-cli
Signed-off-by: Chris Crone <christopher.crone@docker.com>
2020-08-21 17:28:39 +02:00
Djordje Lukic
635ecd7b99 Return a default implementation when nil
Some backends can decide not to implement a whole set of APIs (compose
for example), we now return a default implementation that returns a
`errdefs.ErrNotImplemented` for each action making it easy for the cli
to print a helpful error message. We also remove any possible nil
panics.

Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
2020-08-20 14:32:03 +02:00
Ulysses Souza
2f16ca1e7a Fix e2e-local tests when compiled with go1.14
Check https://github.com/golang/go/commit/64cfe9f

Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-08-14 09:45:03 +02:00
Djordje Lukic
9a29037e0f Put 40 seconds for timeout instead of 20
For some reason this test fails on CI with a timeout.
2020-08-13 09:50:06 +02:00
Chris Crone
65fb6020a0 tests.e2e: Check Windows specific error
Signed-off-by: Chris Crone <christopher.crone@docker.com>
2020-08-10 15:06:20 +02:00
Chris Crone
6e99119a4b tests.e2e: Fix Windows tests
Signed-off-by: Chris Crone <christopher.crone@docker.com>
2020-08-10 14:26:47 +02:00
Chris Crone
017053e19a tests.e2e: Refactor
Signed-off-by: Chris Crone <christopher.crone@docker.com>
2020-08-10 14:12:46 +02:00
aiordache
648f0139df add e2e test for compose up on default context
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-07-29 17:33:23 +02:00
Christopher Crone
eac315c6ec tests: Fix logout test on Windows
The macOS/Linux output when logging out from a registry that you're not
logged into is different to that of Windows. As the login test doesn't
really test if the registry login works, the test now just checks that
the command is properly parsed.

Signed-off-by: Christopher Crone <christopher.crone@docker.com>
2020-07-17 16:55:12 +02:00
Christopher Crone
d1a929eb7f cli: Fix logout when specifying a registry
Signed-off-by: Christopher Crone <christopher.crone@docker.com>
2020-07-17 16:29:12 +02:00
Guillaume Tardif
492ce96dd4 Implement azure logout 2020-07-08 17:48:10 +02:00
Guillaume Tardif
a2ea2347ba Remove It() in e2e tests, simplified step declaration. Nicer test output for all tests 2020-07-08 16:54:45 +02:00
Guillaume Tardif
ae76e0cf27
Merge pull request #325 from docker/error_status_context_needs_login
Specific exit code when command fails because azure login is required
2020-07-02 17:02:57 +02:00
Guillaume Tardif
5eea111ecf Run containers and attach to logs by default, detach with -d option 2020-07-02 16:45:04 +02:00
Guillaume Tardif
964e331a10 Specific exit code when command fails because azure login is required. Will be used by VSCode Docker integration 2020-07-02 13:52:57 +02:00
Guillaume Tardif
d97f9d68fd Add missing f shorthand for version command 2020-06-26 12:35:51 +02:00
Guillaume Tardif
fa8b911cd8 Allow running docker -v or --version even if context is not default 2020-06-23 15:13:43 +02:00
Guillaume Tardif
4197ef8b68
Merge pull request #263 from docker/fix_host_flag
Shell out to Moby cli if user uses -H, regardless of context set.
2020-06-23 14:57:54 +02:00
Guillaume Tardif
ab39310771 Allow --format on docker context ls. Fixing VS Code extension shellout 2020-06-23 13:25:43 +02:00
guillaume.tardif
4afdc69bb7 e2e test running on windows, default endpoint is npipe on windows 2020-06-23 12:49:02 +02:00
Guillaume Tardif
38d4f8d25a Shell out to Moby cli if user uses -H, regardless of context set. Moby cli will refuse both options (context & host) to be set at the same time 2020-06-23 12:00:46 +02:00
Guillaume Tardif
03f11e2953
Merge pull request #247 from docker/main_command_cleanup
Main command cleanup
2020-06-23 10:35:07 +02:00
Guillaume Tardif
c3924f2e8e Add -H flag to our own version command & login command, & also —-log-level (-l) flag. 2020-06-22 18:22:18 +02:00
Guillaume Tardif
2824a7a736 Context aci create : check context name does not exists before starting interactive aci create 2020-06-22 18:20:40 +02:00
Djordje Lukic
ad72c866cc Add license headers 2020-06-18 16:48:03 +02:00
Guillaume Tardif
3981244701 Fix bug where we shell out to Moby cli only if context == default. We must shell out to Moby cli for any context of type “Moby”, not only the default context. 2020-06-18 09:25:28 +02:00
Guillaume Tardif
fe57e4c159 Fix a bug where calling login, context inspect did not do anything if not on default context. These command will shell out to Moby cli regardless of current context 2020-06-18 09:25:28 +02:00
Guillaume Tardif
1bb2909d1a Do not restrict docker inspect to 1 arg, can be zero (inspect current context), one or several.
Especially, inspect with zero param is already used by VSCode. Cf https://github.com/docker/desktop-microsoft/issues/19
2020-06-18 09:21:48 +02:00
Guillaume Tardif
bbcdad39d5 Renamed docker-classic to “com.docker.com”. 2020-06-17 17:57:53 +02:00
Guillaume Tardif
830914cb15 Prepare for release 0.1.0 2020-06-17 08:41:54 +02:00
Guillaume Tardif
2a49c3b32f added -q flag to docker context ls. (This is now used in desktop e2e wsl2 tests)
See https://ci-next.docker.com/teams-desktop/blue/organizations/jenkins/desktop%2Fdesktop-test-single-branch-win/detail/desktop-test-single-branch-win/274982/pipeline/
2020-06-17 07:40:27 +02:00
Guillaume Tardif
ef2f90b334 Fix e2e 2020-06-16 15:55:03 +02:00
Ulysses Souza
5b1522095b Fix linter
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-06-16 10:59:40 +02:00