Matt Landis
12916b75a2
tilt: ignore a few more vim swap files ( #2190 )
2019-09-12 11:57:39 -04:00
Maia McCormick
e3948f6bae
ignore: auto-ignore jetbrains .idea file ( #2065 )
2019-08-15 14:38:44 -04:00
Dan Miller
91a2bdd6de
model: move to pkg ( #2024 )
2019-08-09 12:52:31 -04:00
Nick Santos
ce61e7bf18
ignore: improve the ephemeral temp file patterns [ch2663] ( #1925 )
2019-07-29 11:18:22 -04:00
Nicolas De Loof
b19df5c96c
add support for `excludes` and `rebuild`
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2023-02-10 17:24:48 +01:00
Nicolas De Loof
7a42ba7eec
use CGO to enable fsevent on OSX
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2023-02-10 17:24:48 +01:00
Nicolas De Loof
1640f155e9
initial support for `sync`
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2023-02-02 14:59:30 +01:00
Nicolas De Loof
e63cbfba0e
use tilt watcher to track filesystem changes
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2023-02-02 14:59:30 +01:00
Nicolas De Loof
25576289c8
adjust code and dependencies
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2023-02-02 14:59:30 +01:00
Nick Santos
7d6ee74e62
cleanup deprecated ioutil functions ( #5919 )
...
Signed-off-by: Nick Santos <nick.santos@docker.com>
Signed-off-by: Nick Santos <nick.santos@docker.com>
2023-02-02 14:59:30 +01:00
Nick Santos
c08e07714a
watch: optimization to help avoid inotify nodes for large file trees ( #5769 )
...
fixes https://github.com/tilt-dev/tilt/issues/5764
2023-02-02 14:59:30 +01:00
Matt Landis
cf31462398
tests: make test fixtures responsible for tearing themselves down ( #5512 )
2023-02-02 14:59:30 +01:00
Ken Sipe
1b71e3efb3
lint: fix local-prefixes for goimports ( #5453 )
...
Fix local-prefixes on linters imports then resolved imports to be as expected
Signed-off-by: Ken Sipe <kensipe@gmail.com>
2023-02-02 14:59:30 +01:00
Milas Bowman
4d822676ce
ci: add exportloopref linter and upgrade to golangci-lint v1.43.0 ( #5281 )
...
`exportloopref` - detects captures of loop variable without
re-assignment
NOTE: There can be false negatives with this linter to avoid being
overly strict and annoying!
Also upgraded `golangci-lint` to latest (v1.43.0 published 2021-11-03).
2023-02-02 14:59:30 +01:00
Milas Bowman
6fc0b6ff27
build: ensure file handles properly closed ( #5298 )
...
I've been running the test suite (`./internal/engine` in particular)
with `-count X` a lot recently to catch timing-related test failures.
After running enough times, the tests start failing due to too many
open files, so I did an audit and found a few places where files or
readers weren't always being closed.
2023-02-02 14:59:30 +01:00
Nick Sieger
ab84b6ac5b
Fix local go_lintfix errors ( #5191 )
...
* lint: add make lintfix and run it
Fixes all errors like:
```
File is not `goimports`-ed with -local github.com/tilt-dev/tilt (goimports)
```
* git: change to use TrimSuffix
* build: remove unnecessary cast
2023-02-02 14:59:30 +01:00
Milas Bowman
7161778ccf
watch: use WalkDir to speed up file listing ( #4684 )
...
`WalkDir` is new in Go 1.16 and avoids calling `os.Lstat` on
every visited file and directory. In most cases, we don't need
that info, so this will help reduce I/O when listing files,
which can be helpful for particularly big monorepos.
2023-02-02 14:59:30 +01:00
Nick Santos
1f5bfe8882
test: clean up test loggers a bit ( #4580 )
2023-02-02 14:59:30 +01:00
Milas Bowman
f79c75ab10
test: fix lint errors on Darwin (macOS) ( #4247 )
...
Unused code linter isn't particularly smart about platform build
tags, so since this func is only used by the "naive" (non-macOS)
file watcher, it needs to live with that or it gets flagged as
dead code when linting on macOS.
2023-02-02 14:59:30 +01:00
Nick Santos
e62993a854
test: enable unused check, remove dead code ( #4208 )
2023-02-02 14:59:30 +01:00
Nick Santos
28251e8be5
watch: improve error messages when you run out of inotify instances ( #3960 )
2023-02-02 14:59:30 +01:00
Nick Santos
c7ba7d9de5
dockerignore: convert ignore patterns to absolute paths [ch9237] ( #3743 )
...
In most places in Tilt, we try to use absolute paths everywhere.
So this makes things more consistent with the rest of Tilt, and lets us be
a bit more flexible in how we handle subdirs and parent dirs in ignores.
Fixes https://github.com/tilt-dev/tilt/issues/3740
2023-02-02 14:59:30 +01:00
Nick Santos
8b39322365
watch: fix a dumb errcheck ( #3622 )
2023-02-02 14:59:30 +01:00
Nick Santos
b3615d64e2
watch: increase the windows watch i/o buffer ( #3620 )
...
fixes https://github.com/tilt-dev/tilt/issues/3556
2023-02-02 14:59:30 +01:00
Nick Santos
1a1d1707ed
change org name from windmilleng to tilt-dev ( #3346 )
2023-02-02 14:59:30 +01:00
Nick Santos
fd3e0bbe2b
watch: use the recursive watcher on windows ( #3306 )
2023-02-02 14:59:30 +01:00
Nick Santos
d2d4d05264
Revert "watch: fix inotify tests on windows" ( #3147 )
...
This reverts commit 74ac7997b1c8f497babbbd499ff1f047563d699a.
2023-02-02 14:59:30 +01:00
Nick Santos
dda0362b6e
watch: fix inotify tests on windows ( #3140 )
2023-02-02 14:59:30 +01:00
Nick Santos
ddc88ec41b
circleci: run make shorttest on windows. flag off a large swath of broken tests ( #3132 )
2023-02-02 14:59:30 +01:00
Matt Landis
92c6a65a03
tilt: enable errcheck on tests ( #2877 )
2023-02-02 14:59:30 +01:00
Dan Miller
00b3caecbb
ci: enable staticcheck, fix problems that were surfaced ( #2809 )
2023-02-02 14:59:30 +01:00
Dan Miller
17087447e9
logger: move to pkg ( #2031 )
2023-02-02 14:59:30 +01:00
Nick Santos
ec781687fd
watch: add retry counts to fsync ( #2023 )
2023-02-02 14:59:30 +01:00
Nick Santos
b22dde9f18
dockerignore: improve MatchesEntireDir ( #1865 )
2023-02-02 14:59:30 +01:00
Nick Santos
a31350ede1
watch: move more of the directory-skipping logic into the interface ( #1864 )
2023-02-02 14:59:30 +01:00
Nick Santos
d744c97f13
watch: add a simple check when there are no exclusions ( #1863 )
2023-02-02 14:59:30 +01:00
Nick Santos
37647bc600
watch: skip setup if nothing is being watched ( #1861 )
2023-02-02 14:59:30 +01:00
Nick Santos
21e5d564af
watch: FileEvents must always be absolute ( #1841 )
...
there were a lot of confused tests that were using relative paths, then trying to workaround this
2023-02-02 14:59:30 +01:00
Nick Santos
390d5cf165
watch: add tests for ignores and number of watches ( #1838 )
2023-02-02 14:59:30 +01:00
Nick Santos
7f6e189dbc
watch: change the watcher interface to better match how we actually use it ( #1835 )
2023-02-02 14:59:30 +01:00
Dan Miller
b5ccea7b0e
watch: record num watches in expvars ( #1795 )
2023-02-02 14:59:30 +01:00
Matt Landis
47551895f3
makefile: fix goimports -local ( #1763 )
2023-02-02 14:59:30 +01:00
Nick Santos
5e0f1eec16
watch: fix spurious errors while watching ( #1726 )
2023-02-02 14:59:30 +01:00
Dan Bentley
f82e2de57e
watch: don't watch each individual file ( #1613 )
2023-02-02 14:59:30 +01:00
Matt Landis
9c7f7bc0fa
live_update: error if syncing from outside of docker context ( #1396 )
2023-02-02 14:59:30 +01:00
Nick Santos
6defe7cac6
watch: tfw you have a test that asserts broken file-watch behavior 😢 ( #1354 )
2023-02-02 14:59:30 +01:00
Dan Miller
0482f9276a
watch: add watch function that traverses up directory structure recursively ( #1013 )
2023-02-02 14:59:30 +01:00
Nick Santos
e8a34c8d1e
watch: remove inotify-specific bits of watcher_linux ( #890 )
...
the tests on windows don't pass yet, but at least it compiles
2023-02-02 14:59:30 +01:00
Nick Santos
9e261c18b3
watch: fix a bug when a file and its ancestor both have direct watches ( #863 )
2023-02-02 14:59:30 +01:00
Nick Santos
1fd7ca5440
testing: update internal/watch to use the tempdir fixture ( #862 )
2023-02-02 14:59:30 +01:00