85c94a2f7f
Replace `docker run —envFile` with `docker run —env-file`
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-16 18:03:47 +02:00
05295b5e8a
Merge pull request #765 from docker/ecs_default_profile
...
Populate ~/.aws/config(credentials) on ecs context create
2020-10-16 11:33:03 +02:00
c2af0a136a
Populate ~/.aws/config(credentials) on ecs context create
...
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-10-15 20:26:38 +02:00
50a2ae1100
Display summary of reclaimed ACI resources (CPU/mem) in `docker prune`
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-15 15:45:48 +02:00
a5e34323e2
Add `docker prune` command and ACI implementation
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-14 17:48:11 +02:00
660c7bbdcf
Add command "volume inspect"
...
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-10-14 11:11:55 +02:00
6c1ea32dae
Add --quiet for some commands
...
- compose ls
- compose ps
- secret ls // Not implemented on ACI so no e2e-aci tests
- volume ls
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-10-12 11:34:27 +02:00
a067882b6d
Merge pull request #734 from docker/add-version-in-user-agent
...
Add version to UserAgent on ACI
2020-10-12 11:11:55 +02:00
10632b008b
Add version to UserAgent on ACI
...
This also refactors the Version insertion to make it global
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-10-12 09:15:32 +02:00
6516632ecf
Add resource reservations to container inspect
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-08 17:47:16 +02:00
b1edfb6507
Change inspect json output to group things a bit more nicely, and more like Moby json output
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-08 17:03:30 +02:00
0d3f7186c5
Hardcoded list of commands and simplified metrics gathering.
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-08 11:59:12 +02:00
265dd197c3
Add detach flag to `compose up`
...
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-10-07 15:51:43 +02:00
a1bb2d5abe
Allow `docker context ls —formatter {{json.}}` to not delegate to Moby and include context type in the json
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-06 18:00:35 +02:00
c15d05f7f4
refactor task failure detection
...
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-10-05 19:37:13 +02:00
d3effd2ead
Detect task failures
...
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-10-05 16:55:35 +02:00
144c403e96
Merge pull request #721 from ahlaw/main
...
Normalize case of command and flag help
2020-10-05 11:45:47 +02:00
97576db803
Merge pull request #689 from ulyssessouza/json-out
...
Add json output format to several commands
2020-10-05 10:30:30 +02:00
e10424e316
Normalize case of command and flag help
...
Signed-off-by: Amos Law <ahlaw.dev@gmail.com>
2020-10-03 20:43:18 -04:00
344db70274
Fix version command on bypassing to moby cli
...
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-10-02 19:04:43 +02:00
74e86ab06a
Fix HTML escape encoding
...
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-10-02 18:53:22 +02:00
6d0f7f399f
Fix regression: let users login to local registry (no '.' In registry name)
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-02 13:54:59 +02:00
83f21b9293
Remove unused files
...
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-10-01 15:41:18 +02:00
b8a1e6c888
Change JSON output to individual lines
...
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-10-01 15:41:18 +02:00
3e9095a873
Fix docker context ls for retrocompatibility
...
It writes each context as an independent object line
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-10-01 15:41:18 +02:00
6c883dc4a5
Print only the information present in pretty on json
...
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-10-01 15:41:18 +02:00
604cf0c911
Add comment on legacy --json option
...
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-10-01 15:41:18 +02:00
044e7f571d
Remove go template from help on list commands
...
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-10-01 15:41:18 +02:00
fb59c9385d
Fix tests
...
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-10-01 15:41:18 +02:00
0f6f547214
Refactor Print method for lists
...
This also fixes in the case of nil list
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-10-01 15:41:18 +02:00
8961805412
Add json output format to several commands
...
- docker context ls
- docker ps
- docker compose ls
- docker compose ps
- docker secret ls
- docker volume ls
- docker version
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-10-01 15:41:18 +02:00
abd6af6386
Merge pull request #704 from ulyssessouza/add-envFile
...
Add envFile arguments to run command
2020-10-01 13:55:24 +02:00
0ac5ce6a76
Merge pull request #702 from gtardif/run-args
...
Add argument support to run command
2020-10-01 11:22:03 +02:00
2e899202ec
Add envFile arguments to run command
...
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-10-01 06:19:08 +02:00
277702dc6b
Add argument support to run command
...
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-09-30 15:34:22 +02:00
b8968e83cd
Do not fail when constructing error message for commands not implemented. Use metrics GetCommand() the is already used 3 lines above for metrics tracking.
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-30 10:49:14 +02:00
b9d6c2e701
Add volume as a new served API, use `one of` in proto for context specific parameters, proxy volume creation
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-28 14:56:32 +02:00
7b169744a2
cli: Sort main imports
...
Signed-off-by: Chris Crone <christopher.crone@docker.com>
2020-09-25 14:28:26 +02:00
ca35ccfb0e
ACI Volumes : create takes one required arg, instead of required flag `--fileshare` (we still have required flag `--storage-account` specifically for ACI)
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-24 17:10:32 +02:00
8302266212
In metrics, send context type, not context name (metrics for Moby calls)
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-23 16:12:09 +02:00
cf3bb18c0e
User compose.service.domainname rather than custom ACI extension for ACI DNSLabelName
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-22 14:44:22 +02:00
334ebf5f75
Implement --domainname flag on compose up, also defining compose extension "x-aci-domain-name" to store ACI DNSLabelName.
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-22 14:41:31 +02:00
268c02523a
Only add `--domainname` flag to `docker run` in ACI context
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-22 14:41:31 +02:00
701d1b834e
ACI: allow users to set DNSLabelName and deploy containers with fqdn like `myapp.eastus.azurecontainers.io`
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-22 14:41:31 +02:00
f42e05fcc3
Merge pull request #636 from docker/update-copyright
...
Update copyright
2020-09-22 12:21:16 +02:00
772493d70d
Merge pull request #617 from ulyssessouza/volumes_ro
...
Add 'readOnly' capability to volumes on ACI
2020-09-22 12:14:31 +02:00
d154c41586
Update copyright
...
Signed-off-by: Chris Crone <christopher.crone@docker.com>
2020-09-22 12:13:00 +02:00
a71b2a39bd
Add status field in API metrics
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-18 15:22:34 +02:00
02d59ae510
Add 'readOnly' capability to volumes on ACI
...
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-09-18 12:07:42 +02:00
3ccc603461
Add status field in CLI metrics : success, failure, cancelled
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-18 10:47:50 +02:00
10372b7098
Merge pull request #625 from docker/aci_context_create_no_sub
...
Check specified subscription in context create and if not found, prompt users they might need to login with -—tenant-id.
2020-09-17 22:29:06 +02:00
292ec55f46
Check specified subscription in context create and if not found, prompt users they might need to login with -—tenant-id.
...
Cf https://github.com/docker/aci-integration-beta/issues/27
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-17 22:05:43 +02:00
9c6aead797
Allow running commands with HOME=“”.
...
Do not try to create ~/.docker before using CONFIG_DIR. HOME=“” will result in trying to use a relative .docker folder as default config folder, and if we cannot create the context store for any reason, try delegate to Moby CLI.
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-17 09:08:17 +02:00
6d35a6d644
Merge pull request #609 from docker/refacto_multi_error_format
...
Remove duplicated code formatting multi errors
2020-09-15 18:14:45 +02:00
267b267201
Progress functions can return a string, that can be used in the caller of progress.Run to display final result after progress display
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-14 14:29:03 +02:00
2ce4e98d88
In version, replace “Azure integration” version info by “Cloud integration”
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-11 17:29:40 +02:00
b85eddd09c
Remove duplicated code formatting multi errors
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-11 16:08:14 +02:00
57ded74aee
Merge pull request #598 from docker/encode_env_values
...
Properly send env variables containing “=“ in their value in ACI payload. Also properly send quoted values
2020-09-10 17:17:02 +02:00
98f0064fe9
Properly send env variables containing “=“ in their value in ACI payload. Also properly send quoted values
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-10 17:03:34 +02:00
0b3fdb637d
Change volume IDs from “storageaccount@fileshare“ to “storageaccount/fileshare”
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-10 16:07:22 +02:00
07547d7b87
ACI Volume create flags are required
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-10 15:24:51 +02:00
099b64935b
Minor fixes
...
Co-authored-by: Chris Crone <christopher.crone@docker.com>
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-10 14:55:46 +02:00
80d23a6097
Removed NAME from `volume ls` output, allow `volume delete <ID>` using IDs from `volume ls`.
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-10 09:14:39 +02:00
38a8f5310b
Volume command is only available in aci context type, with ACI specific flags
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-10 09:14:39 +02:00
b96a6d1086
Add progress on volume creation
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-08 17:54:45 +02:00
96d785a5bd
Added volume delete, can delete juste a file share or the storage account if confirmed
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-08 16:32:16 +02:00
dcbc1c3fb2
Volume cli minor refactor
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-08 15:30:50 +02:00
08562b403e
Connecting it all
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-08 15:30:50 +02:00
9ed06ece5b
Adding volume API & initial CLI command
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-08 15:30:50 +02:00
64a28f6636
Also move client => api/client
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-07 13:23:06 +02:00
d06aa2827f
Move containers, compose, secrets to /api
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-07 13:22:08 +02:00
f24f02bbbb
Merge pull request #581 from docker/remove_delete_alias
...
Remove delete alias, no reason to add this (does not exist in Moby)
2020-09-04 15:47:27 +02:00
a8c290fe98
Merge pull request #583 from docker/compose_ls
2020-09-04 14:13:27 +02:00
1a41d0a90b
Remove delete alias, no reason to add this (does not exist in Moby)
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-04 13:22:28 +02:00
02be463fd7
Add `compose ls` command for ECS
...
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-09-04 13:20:11 +02:00
303958bb44
Merge pull request #574 from ulyssessouza/alias-rm-kill
...
Add 'kill' as an alias to 'stop'
2020-09-04 13:07:38 +02:00
adeba9b124
Fix bug not allowing users to run any context command when set to an aws context type.
...
When users have an “aws" context type, we try to exec the command (will execute context ls, context use, etc.) and when it fails because it doesn’t find the aws backend, then display the custom error for aws context type.
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-04 11:01:55 +02:00
15066ce999
Add 'kill' command
...
- On ACI that's implemented as a stop,
since ACI does not implement a kill
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-09-04 02:57:54 +02:00
c7e2db077e
Merge pull request #544 from docker/simulation
...
Introduce ECS emulation mode
2020-09-01 15:18:32 +02:00
fed50d79f2
introduce ecs-local context
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-08-31 15:30:05 +02:00
7f8bb030e6
Introduce ECS emulation mode
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-08-31 10:01:52 +02:00
b0c50ed6dd
Implement compose ps on ACI
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-08-28 17:43:18 +02:00
f80e90caca
Merge pull request #529 from docker/api
...
Revisit compose API so it uses compose-go Project as parameter
2020-08-27 11:52:27 +02:00
edb30e7e82
Revisit compose API so it uses compose-go Project as parameter
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-08-27 10:59:20 +02:00
ed395a1e64
Display nice message on context creation (message taken from Moby cli)
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-08-26 18:09:01 +02:00
ad5c465bd1
Merge pull request #485 from docker/repo-rename
...
Rename docker/api -> docker/compose-cli
2020-08-25 15:58:51 +02:00
59f7d7cd00
Redirect user from plugin usage to integrated ECS
...
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-08-24 19:29:10 +02:00
4c6280b0e9
Rename docker/api -> docker/compose-cli
...
Signed-off-by: Chris Crone <christopher.crone@docker.com>
2020-08-21 17:28:39 +02:00
69ce33321f
Merge pull request #528 from docker/secrets
...
Secrets
2020-08-21 14:52:36 +02:00
4c3b563182
ECS context type is not for delegation to Moby !
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-08-21 14:32:46 +02:00
32adf3e4e6
Introduce `secret` management command and ECS implementation
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-08-21 13:56:52 +02:00
bff1fa1872
Merge pull request #525 from docker/workingdir
...
workdir default value is defined by compose file
2020-08-21 10:22:31 +02:00
838937c907
workdir default value is defined by compose file
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-08-20 15:18:03 +02:00
635ecd7b99
Return a default implementation when nil
...
Some backends can decide not to implement a whole set of APIs (compose
for example), we now return a default implementation that returns a
`errdefs.ErrNotImplemented` for each action making it easy for the cli
to print a helpful error message. We also remove any possible nil
panics.
Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
2020-08-20 14:32:03 +02:00
2df4112913
Merge pull request #511 from docker/ecs-e2e
...
First ECS E2E test
2020-08-20 10:57:23 +02:00
9b0b1129a6
Build without ecs build flag, not required anymore. Fix context create ecs command not build
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-08-20 10:11:23 +02:00
6657dd2774
Add error message for aws context
...
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-08-19 18:22:07 +02:00
44b2b8b21d
integrate functionality from ecs-plugin
...
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-08-19 17:49:21 +02:00
fe0cc0d2cc
Add progress.Run to down cmd
...
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-08-19 16:19:21 +02:00
ec4615ae57
Apply linter recommendations
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-08-19 08:16:19 +02:00
Guillaume Tardif
Anca Iordache
aiordache
Ulysses Souza
Nicolas De loof
Amos Law
Chris Crone
Djordje Lukic