tyler.durden/compose
1
0
Fork 0
mirror of https://github.com/docker/compose.git synced 2025-04-08 17:05:13 +02:00
Code Issues Packages Projects Releases Wiki Activity
3,292 Commits 23 Branches 268 Tags
Commit Graph

240 Commits

Author SHA1 Message Date
Guillaume Lours
d5528f3a54
Merge pull request #9520 from milas/bugfix-network-ambiguity 
fix: prevent network name ambiguity
 2022-06-02 12:44:12 +02:00
Laura Brehm
81182fca53 Add links to container create request. 
In v1, links were sent alongside the rest of the container create request, as part of `HostConfig`. In v2, links are usually set on the connect container to network request that happens after the create. However, this only happens if the service has one or more networks defined for it. If the services are configured to use the default bridge network, this request is not made and so links are never configured.

Signed-off-by: Laura Brehm <laurabrehm@hey.com>
 2022-06-02 02:51:25 +02:00
Milas Bowman
7f32f02817 fix: prevent network name ambiguity 
`NetworkInspect` will match a network ID by prefix. While rare,
it's possible that users might use a network name that is also
a valid network ID prefix for a pre-existing Docker network.
(In the reported case, the network was named `db`, for example.)

Fixes #9496.

Signed-off-by: Milas Bowman <milas@tilt.dev>
 2022-06-01 15:28:42 -04:00
Guillaume Lours
335decceda
Merge pull request #9504 from docker/nicksieger/9427 
fix: bring up services with deps with --no-deps
 2022-05-31 23:39:19 +02:00
Nick Sieger
28c0fbfdc0
e2e: reproduce bug with links 
Signed-off-by: Nick Sieger <nick@nicksieger.com>
 2022-05-31 16:32:29 -05:00
Nick Sieger
cacff89cef
fix: bring up services with deps with --no-deps 
Don't fail on not finding dependent services because they were put in the
disabled slice.

Fixes #9427.

Signed-off-by: Nick Sieger <nick@nicksieger.com>
 2022-05-31 16:19:21 -05:00
Guillaume Lours
a1b3f95709
add e2e tests to verify env variables priority 
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
 2022-05-30 17:11:49 +02:00
Guillaume Lours
e806acce88
Merge pull request #9481 from glours/add-tags-to-build 
add tags property to build section
 2022-05-23 10:23:40 +02:00
Guillaume Lours
285a9c94f7
Merge pull request #9476 from maxcleme/9469-fix-flickering-prompt 
fix: prevent flickering prompt when pulling same image from N services
 2022-05-20 22:09:02 +02:00
Ulysses Souza
b961d49859
Merge pull request #9033 from ulyssessouza/add-e2e-ddev 
Add ddev's e2e test
 2022-05-20 20:02:58 +02:00
Guillaume Lours
9cae9eb0fe
Merge pull request #9488 from ndeloof/attach_profiles 
attach _only_ to services declared by project applying profiles
 2022-05-20 14:38:08 +02:00
Nicolas De Loof
8d03e29994
attach _only_ to services declared by project applying profiles 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
 2022-05-20 10:36:06 +02:00
Guillaume Lours
7ee7becd01 fix TestLocalComposeUp which fail locally 
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
 2022-05-20 07:36:34 +02:00
Randy Fay
97d46a14ef Fix problems with ddev e2e test and minor cleanup, add tmate (#27) 
* Add tmate for debugging
* Use -parallel=1 for standaone tests

Signed-off-by: Randy Fay <randy@randyfay.com>
 2022-05-19 14:14:03 +02:00
Ulysses Souza
a5a1c5f2f1 Add ddev's e2e test 
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
 2022-05-19 14:14:03 +02:00
Guillaume Lours
a2770b66ff
add tags property to build section 
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
 2022-05-18 14:43:54 +02:00
Maxime CLEMENT
48b150beff fix: prevent flickering prompt when pulling same image from N services 
Signed-off-by: Maxime CLEMENT <maxime.clement@docker.com>
 2022-05-18 08:58:06 +02:00
Nicolas De Loof
65b827d08f
bump compose-go to 1.2.5 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
 2022-05-17 17:11:32 +02:00
Guillaume Lours
a603e27117 cp command from service to host: use the first container found to copy source on the host 
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
 2022-05-10 10:50:40 +02:00
Guillaume Lours
a964d5587b align cp command index management with exec command 
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
 2022-05-10 10:50:40 +02:00
Guillaume Lours
a983cf551d cp command: copy to all containers of a service as default behaviour 
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
 2022-05-10 10:50:40 +02:00
Nicolas De Loof
78b06764a1
compose down exit=0 if nothing to remove 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
 2022-05-04 13:51:21 +02:00
Eric Fan
41b3967cb5 Fix cannot setup IPAM gateway 
Signed-off-by: Eric Fan <ericfan@qnap.com>
 2022-04-24 17:30:27 +02:00
Nicolas De Loof
00fd1c1530 inspect image ID after pull to se com.docker.compose.image 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
 2022-04-21 22:42:29 +02:00
Nicolas De Loof
0dffd5ba9f add support for build.secrets 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
 2022-04-13 22:45:53 +02:00
Nicolas De Loof
e01687430e when using bind API, use compose-go to (re)build volume string 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
 2022-04-13 22:45:53 +02:00
Nicolas De Loof
9668f600d1
project name MUST be lowercase 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
 2022-04-13 09:49:01 +02:00
Nicolas De Loof
672e2367fb don't ignore error 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
 2022-04-12 16:00:36 +02:00
Nicolas De Loof
625a48dcf7 pull to respect pull_policy 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
 2022-04-12 07:59:58 +02:00
Nicolas De Loof
500555b834
linter 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
 2022-04-08 11:41:46 +02:00
Nicolas De Loof
e766352d81
include services declared by links as implicit dependencies 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
 2022-04-08 10:32:36 +02:00
Nicolas De Loof
db698562a9 use project we just created to start services 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
 2022-04-07 13:38:30 +02:00
Guillaume Lours
7fea9f7e8b use project instead of DownOptions.project to list service images in pkg.compose.down 
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
 2022-04-05 08:24:25 +02:00
Nicolas De Loof
c9fbb9ba9c
inspect container before attachment to use the adequate logic regarding TTY 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
 2022-04-04 14:39:38 +02:00
Guillaume Lours
f2d9acd3d4 use ssh config when building from compose up 
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
 2022-04-04 10:16:28 +02:00
Guillaume Lours
fcff36fc8a now we use directly the Docker CLI to run autoremove flag should be pass as is 
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
 2022-04-02 08:45:51 +02:00
Ulysses Souza
56e48f8360 Fix down command without any resource to delete 
A command down without any resource to delete was
trying to remove a default network that doesn't exist

Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
 2022-03-31 18:30:29 +02:00
Guillaume Lours
934b596e00 add e2e tests to check usage of ssh build property 
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
 2022-03-31 12:47:15 +02:00
Guillaume Lours
ff73827a6f Add support of ssh authentications defined in compose file or via cli flags 
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
 2022-03-31 12:47:15 +02:00
Guillaume Lours
9b02add4df
fix race condition on start-stop e2e tests running in parrallel 
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
 2022-03-31 11:16:18 +02:00
Nicolas De Loof
890b6808a2
support cache_from|to|no|pull 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
 2022-03-28 09:36:24 +02:00
Nicolas De Loof
c843d373de restore TTY auto-detection using dockerCli.Out.IsTerminal 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
 2022-03-16 16:34:26 +01:00
Nicolas De Loof
1d4b4e3c8e use docker/cli RunExec and RunStart to handle all the interactive/tty/* terminal logic 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
 2022-03-16 16:34:26 +01:00
Guillaume Lours
d999c230a5
Merge pull request #9281 from ndeloof/down_volume_external 
don't remove external volumes/networks
 2022-03-14 17:21:04 +01:00
Nicolas De Loof
e7f545907b
don't remove external volumes/networks 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
 2022-03-14 15:24:49 +01:00
Guillaume Lours
730609b359
Merge pull request #9280 from ndeloof/kill 
kill only need project name
 2022-03-14 10:33:21 +01:00
Nicolas De Loof
cd8074d501
kill only need project name 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
 2022-03-14 10:26:36 +01:00
Nicolas De Loof
283f7a1ec5 Bump buildx to v0.8.0 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
 2022-03-11 14:05:55 +01:00
Nicolas De Loof
85a4d04096
recreate container after image has been rebuilt/pulled 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
 2022-03-10 11:02:48 +01:00
Nicolas De Loof
5e8040ea18
don't fail trying to remove container with no candidate 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
 2022-03-09 16:24:16 +01:00