60 Commits

Author SHA1 Message Date
Guillaume Tardif
303958bb44
Merge pull request #574 from ulyssessouza/alias-rm-kill
Add 'kill' as an alias to 'stop'
2020-09-04 13:07:38 +02:00
Ulysses Souza
15066ce999 Add 'kill' command
- On ACI that's implemented as a stop,
since ACI does not implement a kill

Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-09-04 02:57:54 +02:00
guillaume.tardif
bb58290eeb invoke browser with Run rather than Start, to get errors (on wsl no interop setup, and more generally if the browser app returns an error)
Signed-off-by: guillaume.tardif <guillaume.tardif@gmail.com>
2020-09-02 17:31:04 +02:00
Guillaume Tardif
909be662ee Azure fallback to device code flow if we can’t open a browser (some WSL2 scenarios)
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-02 15:46:17 +02:00
Guillaume Tardif
b0c50ed6dd Implement compose ps on ACI
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-08-28 17:43:18 +02:00
Guillaume Tardif
f80e90caca
Merge pull request #529 from docker/api
Revisit compose API so it uses compose-go Project as parameter
2020-08-27 11:52:27 +02:00
Guillaume Tardif
2ea000b280 Removed space before :
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-08-27 11:30:48 +02:00
Nicolas De Loof
edb30e7e82
Revisit compose API so it uses compose-go Project as parameter
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-08-27 10:59:20 +02:00
Guillaume Tardif
8dbb6c58b9 Print ACR login debug info
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-08-27 10:50:21 +02:00
Chris Crone
4c6280b0e9 Rename docker/api -> docker/compose-cli
Signed-off-by: Chris Crone <christopher.crone@docker.com>
2020-08-21 17:28:39 +02:00
Guillaume Tardif
dc1e313858 Revert "Debug for CI failing tests (green locally)"
This reverts commit 1d875674357c7c5a5c26349f62c6f2ef71f74e38.

Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-08-21 12:45:01 +02:00
Guillaume Tardif
a8548de5dd Debug for CI failing tests (green locally)
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-08-21 12:44:41 +02:00
Guillaume Tardif
5cab129c10 Add E2E test on deploying ACR images
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-08-19 14:31:45 +02:00
Guillaume Tardif
04c678b099 Do not require refresh token to obtain ACR token. Especially this will make the ACR auto-login feature work with Service Principal login, that does not have a refresh token
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-08-19 14:31:35 +02:00
Nicolas De Loof
66e25937c6
Merge remote-tracking branch 'origin/main' into ecs-import
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-08-19 11:28:31 +02:00
Nicolas De Loof
ec4615ae57
Apply linter recommendations
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-08-19 08:16:19 +02:00
Guillaume Tardif
87cee4d1e5 Returns Node <Group_status> when container group status is available and not container status (instead of Unknown)
Impacts output for ps, inspect

Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-08-18 12:42:00 +02:00
Nicolas De Loof
2791542fea
Merge remote-tracking branch 'origin/main' into ecs
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-08-18 10:36:17 +02:00
Nicolas De Loof
cfbd963c3d
Adjust commands to latest compose-go
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-08-18 10:01:32 +02:00
Nicolas De Loof
6e6a11aa73
Introduce Secrets API
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-08-18 09:43:15 +02:00
Nicolas De Loof
91427d0492
introduce Convert in compose API
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-08-18 08:58:37 +02:00
Nicolas De Loof
e02d8d549b
Make ECS integration a compose-cli backend
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-08-17 21:30:49 +02:00
Guillaume Lours
95de770e87 Update or add license header which are not valid
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
2020-08-17 16:55:25 +02:00
Guillaume Tardif
4ee5aa6267 More renaming 2020-08-14 17:07:33 +02:00
Guillaume Tardif
274dc8283f Use proper context in storage key retrieval 2020-08-14 17:01:44 +02:00
Guillaume Tardif
6552a00004 Use SDK storage.AccountClient.ListKeys. Needed to refactor code to avoid cyclic dependencies 2020-08-14 16:41:38 +02:00
Guillaume Tardif
3a60c957ae Get storage account key from azure login, no need to specify it in compose file or run -v option 2020-08-14 12:26:09 +02:00
Djordje Lukic
13327ac617 Make the compose message on start mean something 2020-08-12 15:10:54 +02:00
Djordje Lukic
1a3182fb7f Implement docker start for ACI 2020-08-12 14:50:47 +02:00
Guillaume Tardif
abd363d641
Merge pull request #463 from docker/compose_labels_error
Explicit error message saying we don’t support labels in compose file
2020-08-12 13:51:32 +02:00
Guillaume Tardif
3d758b7f26 Implement docker ps —all filter on ACI 2020-08-12 11:59:36 +02:00
Chris Crone
52cd3d97c0
Merge pull request #465 from docker/login_redirect
Change docker login azure redirect to docker ACI integration documentation
2020-08-12 11:09:03 +02:00
Guillaume Tardif
6472ffa346 Change docker login azure redirect to docker ACI integration documentation 2020-08-12 10:40:08 +02:00
Guillaume Tardif
ee062e8333 ACI Stop implementation 2020-08-12 10:32:35 +02:00
Guillaume Tardif
8fb16cea63 Explicit error message saying we don’t support labels in compose file. (See ACI limitations: https://github.com/docker/desktop-microsoft/issues/33) 2020-08-12 10:28:55 +02:00
Djordje Lukic
80c1b2246b
Merge pull request #457 from docker/feat-aci-force-rm
Add --force to rm on ACI
2020-08-11 16:42:49 +02:00
Djordje Lukic
093a69136f Add --force to rm on ACI
If a container is running the user must force the removal of the
container.
2020-08-11 16:30:42 +02:00
Guillaume Tardif
ec5f4e9202 Add options to docker login azure to support Service Principal login. Use it in E2E tests 2020-08-11 12:11:51 +02:00
Guillaume Tardif
76d8f5a8b4 More goimport changes 2020-08-10 14:36:05 +02:00
Guillaume Tardif
fffb3aa3f9 Use existing oauth Token struct rather than create our own 2020-08-10 14:35:23 +02:00
Guillaume Tardif
63fd8f2fad ACR autologin. Only warns for autologin errors, as ACR registries might not be related to the user azure login, but they might have external credentials to use ACR images. 2020-08-10 10:42:00 +02:00
Guillaume Tardif
d0a3fb9844 Allow consistent multi container restart policies but provide clear error message for inconsistent restart policies 2020-08-07 15:51:41 +02:00
Djordje Lukic
76cb9f3ad7
Merge pull request #438 from docker/fix-wsl2-azure-login
Fix azure login inside WSL2
2020-08-07 15:42:08 +02:00
Djordje Lukic
8e7a8bfa24 Fix azure login inside WSL2 2020-08-07 12:55:12 +02:00
Anca Iordache
7c8984beaf
Merge pull request #435 from docker/extend_compose_api
Extend the compose API
2020-08-07 11:53:32 +02:00
Christopher Crone
f9f09b3f95 aci: Normalize source code file names
Signed-off-by: Christopher Crone <christopher.crone@docker.com>
2020-08-06 18:52:23 +02:00
Christopher Crone
e4f55ab808 aci: Normalize testing frameworks
Signed-off-by: Christopher Crone <christopher.crone@docker.com>
2020-08-06 18:52:23 +02:00
Christopher Crone
6412b9f638 aci.login: Return pointer to login service
Signed-off-by: Christopher Crone <christopher.crone@docker.com>
2020-08-06 18:52:23 +02:00
Christopher Crone
f41934ed90 aci.login: Normalize testing frameworks
Signed-off-by: Christopher Crone <christopher.crone@docker.com>
2020-08-06 18:52:23 +02:00
Christopher Crone
8bf0610c18 aci.login: Normalize source code file names
Signed-off-by: Christopher Crone <christopher.crone@docker.com>
2020-08-06 18:52:23 +02:00