Commit Graph

1117 Commits

Author SHA1 Message Date
Chris Crone 43d8f2fa18
Merge pull request #351 from chris-crone/error-progress-fix
Set progress event endTime on error
2020-07-06 17:55:51 +02:00
Guillaume Tardif 0776e79e8e Exit without error message if user canceled command (typical scenario : ACI `logs — follow` and ctrl-C while querying ACI) 2020-07-06 17:28:02 +02:00
Guillaume Tardif b1d923d5a0
Merge pull request #347 from docker/inspect_platform
Add ”Platform” in docker inspect result, showing container OS
2020-07-06 17:13:08 +02:00
Guillaume Tardif e4c1a1f945 Fix `docker compose up` with default project name being derived from current working dir. has been fixed upstream in compose-go (see https://github.com/compose-spec/compose-go/pull/56) 2020-07-06 16:56:30 +02:00
Christopher Crone 50d932195d progress: Rename variable to clarify logic
Signed-off-by: Christopher Crone <christopher.crone@docker.com>
2020-07-06 14:03:48 +02:00
Christopher Crone fac4c60077 progress: Add test for error event
Signed-off-by: Christopher Crone <christopher.crone@docker.com>
2020-07-06 13:52:36 +02:00
Christopher Crone 9cc04472fb progress: Stop event on error
Ensures that we set an `endTime` when an error event is published.

Signed-off-by: Christopher Crone <christopher.crone@docker.com>
2020-07-06 13:26:39 +02:00
Guillaume Tardif 8ad53088a3
Merge pull request #344 from gtardif/doc_release
Update doc for release
2020-07-06 13:10:13 +02:00
Guillaume Tardif 2c981f14b3
Merge pull request #342 from docker/feat-aci-metrics
Metrics for azure commands
2020-07-06 13:07:01 +02:00
Guillaume Tardif 7296290408 Add ”Platform” in docker inspect result, showing container OS (this field is used by VSCode) 2020-07-06 12:16:02 +02:00
Djordje Lukic 188dc1b06c Metrics for azure commands
* docker context create aci
* docker login azure
2020-07-06 11:51:11 +02:00
Guillaume Tardif fc8132167e Update doc for release 2020-07-06 09:40:35 +02:00
Guillaume Tardif f2ff8ab669
Merge pull request #341 from docker/better_error_message
Better error message when trying to remove a container from a compose application
2020-07-03 16:03:22 +02:00
Guillaume Tardif dbc109808d Better error message when trying to remove a container from a compose application 2020-07-03 15:58:17 +02:00
Guillaume Tardif aeb446ef4f
Merge pull request #334 from docker/fix_rm_compose_container
Fix rm compose container
2020-07-03 15:42:48 +02:00
Guillaume Tardif da3c3dab1c
@gtardif @rumpl Use %q instead of \"%s\"
Co-authored-by: Djordje Lukic <djordje.lukic@docker.com>
2020-07-03 15:40:25 +02:00
Guillaume Tardif 0dcab4004d
Use %q instead of \"%s\"
Co-authored-by: Djordje Lukic <djordje.lukic@docker.com>
2020-07-03 15:39:44 +02:00
Djordje Lukic c4c0c24dca
Merge pull request #335 from docker/fix-metrics-goroutine
Make sure the metrics goroutine is scheduled
2020-07-03 15:01:14 +02:00
Djordje Lukic 159b9d0cfb Make sure the metrics goroutine is scheduled
Wait for the goroutine to be scheduled before exiting. We don't wait for
the metrics event to be sent, we only make sure the goroutine is called.
2020-07-03 14:58:47 +02:00
Djordje Lukic 1b9dd7ac27
Merge pull request #332 from docker/feat-sleep-ctx
Sleep cancel sleep on log follow if the user cancels
2020-07-03 14:34:18 +02:00
Djordje Lukic c903362d02
Merge pull request #333 from docker/feat-scan-metrics
Implement metrics for `docker scan`
2020-07-03 14:31:16 +02:00
Guillaume Tardif 568dc6de23 Do not allow ACI single containers with name that includes separator used for compose services (this would breaks docker logs, docker exec, docker rm using <CONTAINER_ID>) 2020-07-03 13:39:45 +02:00
Djordje Lukic a97a26bfc3 Implement metrics for `docker scan` 2020-07-03 11:24:00 +02:00
Djordje Lukic 0057093897 Sleep cancel sleep on log follow if the user cancels 2020-07-03 10:51:23 +02:00
Guillaume Tardif 76cb73c5c2 ACI : allow `docker compose down —project-name xxx` without requiring the compose file 2020-07-03 10:24:06 +02:00
Guillaume Tardif 6b74716490 Specific error message when user tries to remove one container from an ACI compose application, mentioning the name of the compose application and that user should use compose down 2020-07-03 10:03:46 +02:00
Guillaume Tardif ae76e0cf27
Merge pull request #325 from docker/error_status_context_needs_login
Specific exit code when command fails because azure login is required
2020-07-02 17:02:57 +02:00
Guillaume Tardif 4a1b50a9cd
Merge pull request #326 from docker/run_follow_logs
Run containers and attach to logs by default, detach with -d option
2020-07-02 17:02:33 +02:00
Guillaume Tardif 5eea111ecf Run containers and attach to logs by default, detach with -d option 2020-07-02 16:45:04 +02:00
Guillaume Tardif 3c83e01e9c
Merge pull request #327 from docker/compose-go
Use compose-go's Project and ProjectOptions
2020-07-02 16:43:34 +02:00
Guillaume Tardif 5a7f780bae
Merge pull request #328 from docker/do_not_wait_cleanup_results
In ACI e2e tests, do not wait for full resource group deletion at the end
2020-07-02 16:43:19 +02:00
Guillaume Tardif a9ef20eefd In ACI e2e tests, do not wait for full resource group deletion at the end, let ACI clean things UP (timeframe ~45 sec). This is costing GH Action minutes for nothing, and slows test results. 2020-07-02 16:13:38 +02:00
Nicolas De Loof 622402709a
Use compose-go's Project and ProjectOptions
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-07-02 16:05:45 +02:00
Guillaume Tardif 42b516e738
Merge pull request #323 from docker/fix-log-lines
Count the lines from the terminal, not from ACI
2020-07-02 14:00:11 +02:00
Guillaume Tardif 2f90715ba2
Merge pull request #321 from docker/dependabot/go_modules/github.com/Azure/azure-storage-file-go-0.8.0
Bump github.com/Azure/azure-storage-file-go from 0.7.0 to 0.8.0
2020-07-02 13:59:55 +02:00
Guillaume Tardif 15cdcf831e
Merge pull request #324 from docker/fix-non-console
Make sure we can have a console
2020-07-02 13:58:48 +02:00
Guillaume Tardif 964e331a10 Specific exit code when command fails because azure login is required. Will be used by VSCode Docker integration 2020-07-02 13:52:57 +02:00
Djordje Lukic e4354c82d1 Make sure we can have a console 2020-07-02 11:49:39 +02:00
Djordje Lukic d3f1209bab Add test for the backtracking of lines 2020-07-02 11:11:09 +02:00
Djordje Lukic e852e8f96a Count the lines from the terminal, not from ACI
Count the number of lines output on the terminal wrt the terminal width
so that we can go up the right amount.
2020-07-02 10:38:03 +02:00
Djordje Lukic 8e8c868a70
Merge pull request #322 from docker/fix_attach_logs
Fix logs replacement when streaming logs on windows
2020-07-02 10:37:27 +02:00
Guillaume Tardif 736b7a4707 Fix logs replacement when streaming logs on windows 2020-07-02 10:17:55 +02:00
dependabot-preview[bot] 5462d38969
Bump github.com/Azure/azure-storage-file-go from 0.7.0 to 0.8.0
Bumps [github.com/Azure/azure-storage-file-go](https://github.com/Azure/azure-storage-file-go) from 0.7.0 to 0.8.0.
- [Release notes](https://github.com/Azure/azure-storage-file-go/releases)
- [Changelog](https://github.com/Azure/azure-storage-file-go/blob/master/ChangeLog.md)
- [Commits](https://github.com/Azure/azure-storage-file-go/compare/v0.7.0...v0.8.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-07-01 21:27:44 +00:00
Djordje Lukic 14b2e54c06
Merge pull request #318 from docker/chore-browser
Return an error if unable to open the browser
2020-07-01 16:55:24 +02:00
Djordje Lukic e22b0ba676 Return an error if unable to open the browser
Also use github.com/pkg/browser instead of our own code
2020-07-01 16:47:49 +02:00
Djordje Lukic c9449dbf83
Merge pull request #315 from docker/fix_cve_guava
Fix cve guava
2020-07-01 15:59:32 +02:00
Guillaume Tardif 8bdb4dee77 Remove debug stuff from web images, that is causing apt-get install issues 2020-07-01 15:47:41 +02:00
Guillaume Tardif 514aa50ebc
Merge pull request #313 from docker/azure_multi_tenants
Allow users to specify tenanted when logging into azure (if several tenants for azure account)
2020-07-01 15:46:00 +02:00
Djordje Lukic 41c84ac313
Merge pull request #316 from docker/feat-ecs-metrics
Add ecs as a management command
2020-07-01 15:30:33 +02:00
Djordje Lukic 3a1cb0aaa0 Add ecs as a management command
This, with the "compose" being a management command makes it possible to
track ecs usage. See tests for more info
2020-07-01 15:18:35 +02:00