660c7bbdcf
Add command "volume inspect"
...
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-10-14 11:11:55 +02:00
18ac5d7e66
Merge pull request #774 from gtardif/fix_go_dep_darwin
...
Remove indirect dependency causing error on Darwin build. Adding cross compile in CI build (all PRs)
2020-10-13 17:29:35 +02:00
699f9a3dfb
Cross compile in CI
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-13 17:16:12 +02:00
c6ac64d66a
Remove indirect dependency causing error on Darwin build. Adding cross compile in CI build (all PRs)
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-13 17:11:37 +02:00
243b0d1b6a
Merge pull request #771 from docker/fix_panic_inspect_empty
...
Fix panic when invoking inspect with empty container id
2020-10-13 15:44:33 +02:00
d8cd4038c2
Fix panic when invoking inspect with empty container id (ACI SDK returns status 200 but nil container group properties)
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-13 15:33:52 +02:00
9e06f42190
Merge pull request #747 from docker/efs_volumes
2020-10-13 15:26:33 +02:00
b25c7696bf
Merge pull request #770 from gtardif/fix_gRPC_regression
...
Put back gRPC fields to avoid API breaking change with existing versi…
2020-10-13 15:11:17 +02:00
a87300d1df
set filesystem name to make it more visible on AWS web console
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-10-13 15:08:40 +02:00
7d8a1398c9
Put back gRPC fields to avoid API breaking change with existing versions of node-sdk, introduced by cfc490fd92
...
(Even though these fields are unused in VSCode Docker extension, removing them and re-using the fields number totally breaks APIs returning containers : ls, inspect)
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-13 15:07:08 +02:00
5d5765173e
Create volume for compose app
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-10-13 14:18:01 +02:00
f7cce91b80
Merge pull request #768 from gtardif/disable_msql_aci_test_again
...
Disabling mysql ACI test again, see https://github.com/docker/compose-cli/runs/1246970427
2020-10-13 12:34:52 +02:00
1a4d45dd06
Too flaky, see https://github.com/docker/compose-cli/runs/1246970427
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-13 12:28:22 +02:00
b1382c9dc3
Merge pull request #766 from docker/debug_aci_db_error
...
Add debug information when mysql cannot start on ACI E2E test
2020-10-13 12:09:00 +02:00
e903326e1a
Check external filesystems exist on compose up
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-10-13 10:43:01 +02:00
9f5f1cc4c3
Add debug information when mysql cannot start on ACI E2E test
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-13 09:37:12 +02:00
be4b9a6812
Merge pull request #760 from docker/add-quiet-flags
...
Add --quiet for some commands
2020-10-13 09:00:58 +02:00
a6e06342d1
Merge pull request #763 from docker/fiw_windows_tests_secrets
...
Trim line returns for windows tests
2020-10-13 08:45:32 +02:00
45bb05ee19
Merge pull request #764 from docker/test_with_mock
...
More unit tests with aws-sdk behind an interface + mocks
2020-10-12 21:21:38 +02:00
7b8255c953
Replaces windows carriage return for windows tests
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-12 17:23:47 +02:00
432ce79e2c
More unig tests with aws-sdk behind an interface + mocks
...
Fix use of existing SecurityGroup
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-10-12 16:51:05 +02:00
a4f10c171e
Test DB Startup timeout 60s => 90s
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-12 16:48:18 +02:00
5b54816a1a
Merge pull request #757 from docker/secrets-refactor
...
Squash all secrets in a single one
2020-10-12 14:40:59 +02:00
45212c6e21
Squash all secrets in a single one
...
Also adds an e2e test
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-10-12 14:17:37 +02:00
8e9c2e5092
Merge pull request #762 from docker/revert_atlas_disabled_tests
...
Revert "Temporarily disable some red ACI tests, to be put reverted on…
2020-10-12 14:16:06 +02:00
0dfea32250
Revert "Temporarily disable some red ACI tests, to be put reverted once the platform is back to green (hopefully in a day or 2)"
...
This reverts commit b10acc1a60
2020-10-12 14:08:22 +02:00
6c1ea32dae
Add --quiet for some commands
...
- compose ls
- compose ps
- secret ls // Not implemented on ACI so no e2e-aci tests
- volume ls
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-10-12 11:34:27 +02:00
a067882b6d
Merge pull request #734 from docker/add-version-in-user-agent
...
Add version to UserAgent on ACI
2020-10-12 11:11:55 +02:00
10632b008b
Add version to UserAgent on ACI
...
This also refactors the Version insertion to make it global
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-10-12 09:15:32 +02:00
a6ef06f131
Merge pull request #753 from docker/secrets-remove-inline
...
Remove inline secrets option
2020-10-09 16:03:38 +02:00
4d6a0bb00d
Remove inline secrets option
...
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-10-09 14:54:12 +02:00
5efebd43c1
Merge pull request #736 from docker/check-volume-usage-on-delete
...
Look for all mounts before removing a volume
2020-10-09 14:46:25 +02:00
99186b1d04
Look for all mounts before removing a volume
...
This checks the volume mounts of all container groups from all
resource groups before removing a volume/fileshare
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-10-09 14:39:21 +02:00
4380adeed5
Merge pull request #751 from docker/fix-string-len-e2e
...
Fix e2e-aci tests on comparing with empty string
2020-10-09 14:36:05 +02:00
289c83efe2
HttpRetry : do not get stuck on first call, timeout http requests and retry in case of failures
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-09 14:27:24 +02:00
4f87422a79
more debug info when ports available but hostIP is empty ; Seems to be a race where container has status running but not yet an IP allocated
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-09 14:09:09 +02:00
019268dded
Fix e2e tests on comparing with empty string
...
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-10-09 13:21:17 +02:00
7fb976732f
Merge pull request #748 from docker/aci_resource_req
...
Aci resource reservation & limits
2020-10-09 12:13:35 +02:00
a2af3c4367
Merge pull request #752 from gtardif/aci_e2E_cleanup
...
Add ACI E2E resource cleanup command
2020-10-09 11:56:16 +02:00
68d0413e36
Minor cleanup
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-09 11:53:53 +02:00
8325768a72
Add ACI E2E resource cleanup command
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-09 10:07:13 +02:00
cfc490fd92
Update gRPC inspect result with HostConfig struct. Breaking changes in inspect API, but this is not used yet in VSCode Docker extension, and still in beta.
...
(Cf https://github.com/microsoft/vscode-docker/blob/master/src/docker/DockerServeClient/DockerServeUtils.ts )
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-08 18:05:52 +02:00
6516632ecf
Add resource reservations to container inspect
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-08 17:47:16 +02:00
b1edfb6507
Change inspect json output to group things a bit more nicely, and more like Moby json output
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-08 17:03:30 +02:00
343d54dac5
Allow to set memory / CPU limits higher than requests, ACI will request that limits are not higher than the total request for the container group. Also set requests = limits when only limits are set
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-08 17:03:30 +02:00
c09f771359
Use compose resource request to set ACI retrouve request, and single container resource requests.
...
Limits should be used to allow one container in a container group to use more than the container requested resources, up to the total resources requested for the container group.
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-08 17:03:30 +02:00
cda66b5e90
Merge pull request #741 from gtardif/fix_cli_metrics
...
Simplify metrics gathering, separate running commands from getting help
2020-10-08 15:34:09 +02:00
0d161f5ccd
Merge pull request #723 from gtardif/doc_aci_compose
...
Compose to ACI mapping documentation
2020-10-08 15:04:17 +02:00
808715d740
Adding secrets details
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-08 14:58:08 +02:00
7ff9162dc7
Remove enterprise specific commands
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-08 14:50:27 +02:00
Ulysses Souza
Guillaume Tardif
Nicolas De loof